NXP backend: Add Neutron backend to /backend/test/suite/operators testing. - #21712
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21712
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 8 PendingAs of commit bfb2aa6 with merge base 92079a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
| pass | ||
|
|
||
| @staticmethod | ||
| @classmethod |
There was a problem hiding this comment.
This change was introduced because the HardTanhConverter inherits from ClampConverter and uses its methods while overriding others. So only ClampConverter implements is_supported_on_target, which internally calls get_bounds which is implemented in botch classes differently. Therefore, is_supported_on_target must be a class method.
(It worked before this commit because the ClampConverter actually defined the is_supported_on_target as a class method, even thought its parent class NodeConverter declared is as a static method.)
f29cc01 to
2538c0f
Compare
|
Can you look into the test failures? |
2d00aab to
5ae2fbb
Compare
All fixed and ready for review. |
novak-vaclav
left a comment
There was a problem hiding this comment.
I really like the integration into the community test harness, good job 🫵👍👍👍
I have a few comments, but nothing serious.
| PYTHON_EXECUTABLE=python NXP_RUNNER_PATH="./examples/nxp/executor_runner/build/nxp_executor_runner" \ | ||
| bash backends/nxp/run_unittests.sh | ||
|
|
||
| test-nxp-testsuite-linux: |
There was a problem hiding this comment.
Take a look at test-backend-*.yml files. These all leverage the reusable _test_backend.yml, and we should probably create a test-backend-nxp.yml job. I recently also setup the backend test harness for cortex-m, you can probably use it as a template. #21854
There was a problem hiding this comment.
Thank you for pointing that out to me.
I have remove the test-nxp-testsuite-linux from pull.yml and instead I created a test-backend-nxp.yml which uses _test_backend.yml based on how you used it for Cortex-M in your PR.
Edit: The job passed and produced the expected test report.
8d3c25f to
a420979
Compare
a420979 to
bfb2aa6
Compare
Summary
Use the testing suite in
/backend/test/suite/operatorsto test the Neutron backend. Currently, all tests are passing except for 2cattests and alllstmtests due to known bugs in the NeutronConverter (so these tests are skipped).Test plan
pytest -c /dev/nul backends/test/suite/operators/ -m backend_nxp -n autocc @robert-kalmar @JakeStevens @digantdesai @rascani