Repository navigation
Enable shikra camx DTB compilation for linux-qcom kernels - #3171
Conversation
|
qli-2.1 pull-request freeze |
|
backport wrynose |
f1dcb48 to
3907012
Compare
Test Results 117 files 717 suites 7h 17m 8s ⏱️ For more details on these failures, see this check. Results for commit 8222193. ♻️ This comment has been updated with latest results. |
|
Ricardo Salveti (@ricardosalveti), Dmitry Baryshkov (@lumag), Shikra camera enablement is a key deliverable for the QLI 2.1 milestone, and this change is required to enable camera support. Since the Shikra DTSO changes have not yet been merged into the qcom-next branch, we have added a conditional check so that the code is compiled only for the QLI 2.x kernel and is excluded from the mainline kernel build. We hope this approach is acceptable and helps us meet the QLI 2.1 timeline while maintaining mainline compatibility. Could you please review the PR and share your feedback? |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
You haven't read CONTRIBUTING.md, have you?
3907012 to
0ebbb52
Compare
|
| qcom/shikra-iqs-evk-imx577-camera.dtbo \ | ||
| " | ||
|
|
||
| # These DTs are not upstreamed and currently exist only in linux-qcom kernels |
There was a problem hiding this comment.
Drop this comment, we know that LINUX_QCOM_KERNEL_DEVICETREE is for dtbs which are not yet available upstream.
There was a problem hiding this comment.
Dropped this comment. Done.
|
See https://github.com/qualcomm-linux/meta-qcom/blob/master/CONTRIBUTING.md#commit-messages for the commit message pattern we use here. |
718a898 to
3ecc1a5
Compare
|
Subject and body still say linux-qcom only, but this now covers linux-qcom and linux-qcom-next. The last paragraph ("Add multi-DTB support…") belongs to the second commit. Also use lowercase enable, as lumag suggested. Please name shikra in the subject, e.g. fit-dtb-compatible: add shikra camx overlay combos. The body repeats the first commit's text; say what the entries do instead: base compatible plus -camx, with the imx577 overlay dropped, as hamoa does. |
3ecc1a5 to
48dbc14
Compare
Updated the commit text. |
I have updated the commit message based on the suggestions. Could you please review it once. |
Dmitry Baryshkov (lumag)
left a comment
There was a problem hiding this comment.
Please fix your editor settings. Line length is too short.
496b774 to
94df16a
Compare
Updated. Please review. |
Downstream camera DTB is not included in the final image when building linux-qcom, linux-qcom-next, linux-qcom-rt, or linux-qcom-next-rt kernels for the shikra EVK boards. This prevents the downstream camera stack from being enabled at boot, even though the kernel supports it. Include the downstream camera DTBO so it is packaged into the final image and downstream camera functionality is available for the shikra cqs, cqm and iqs EVK boards. Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
Add multi-DTB support for camx overlay to enable downstream camera for shikra cqs, cqm and iqs EVK boards. Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
94df16a to
8222193
Compare
|
HI Dmitry Baryshkov (@lumag) , @ricardosalvet, Please review the change and approve it if it meets your expectations. |
|
Known issues. |
9c9c79c
into
qualcomm-linux:master
|
Successfully created backport PR for |
Downstream camera DTB is not included in the final image
when building linux-qcom, linux-qcom-next, linux-qcom-rt,
or linux-qcom-next-rt kernels for the shikra EVK boards.
This prevents the downstream camera stack from being
enabled at boot, even though the kernel supports it.
Include the downstream camera DTBO so it is packaged into
the final image and downstream camera functionality is
available for the shikra EVK boards.
Add multi-DTB support for camx overlay to enable downstream
camera for shikra cqs, cqm and iqs evk boards.