Repository navigation
add: support Ubuntu/Debian kernel config sources - #567
Merged
Srikanth Muppandam (smuppand) merged 1 commit intoOct 9, 2026
Merged
Srikanth Muppandam (smuppand) merged 1 commit into
Srikanth Muppandam (smuppand) merged 1 commit into
Conversation
Srikanth Muppandam (smuppand)
requested changes
Sep 2, 2026
|
|
||
| if [ ! -r /proc/config.gz ]; then | ||
| log_fail "Kernel config source /proc/config.gz is not available" | ||
| if [ -r /proc/config.gz ]; then |
Contributor
There was a problem hiding this comment.
Do not select /proc/config.gz solely because it is readable. On a minimal image it can exist while neither zgrep nor gzip is available, even when /boot/config-$(uname -r) is readable.
This reports every requested config as missing instead of trying the new fallback sources. Validate compressed-config readability with an available decompressor, otherwise continue to plain-text candidates.
| config_name="$1" | ||
| [ -n "$config_name" ] || return 3 | ||
|
|
||
| kcv_kver="$(uname -r 2>/dev/null)" |
Contributor
There was a problem hiding this comment.
Factor kernel-config discovery into one shared helper. This repeats the same source-selection chain added to check_kernel_config(), so precedence and decompressor handling can drift.
Add a small shared kernel_config_source helper in functestlib.sh, returning path and format machine-readably, and compose both public APIs from it.
vnarapar
force-pushed
the
ubuntu_config_enable
branch
from
September 2, 2026 20:06
c4e178e to
cc8325f
Compare
Srikanth Muppandam (smuppand)
requested changes
Sep 3, 2026
vnarapar
force-pushed
the
ubuntu_config_enable
branch
from
September 7, 2026 10:16
cc8325f to
d8cb824
Compare
Srikanth Muppandam (smuppand)
requested changes
Sep 7, 2026
Srikanth Muppandam (smuppand)
left a comment
Srikanth Muppandam (smuppand)
left a comment
Contributor
There was a problem hiding this comment.
split this into two commits:
- utils: discover running kernel config sources
- utils: classify distro families
vnarapar
force-pushed
the
ubuntu_config_enable
branch
2 times, most recently
from
September 15, 2026 11:36
2af2f6d to
00cbe07
Compare
Srikanth Muppandam (smuppand)
requested changes
Sep 16, 2026
vnarapar
force-pushed
the
ubuntu_config_enable
branch
from
October 8, 2026 10:05
00cbe07 to
0c59856
Compare
check_kernel_config() previously only read /proc/config.gz.
- utils/functestlib.sh:
- check_kernel_config(): probe a fallback chain of config sources:
/proc/config.gz -> /boot/config-$(uname -r) ->
/lib/modules/$(uname -r)/build/.config ->
/usr/src/linux-headers-$(uname -r)/.config.
- Updated detect_platform(): classifies the running OS as
ubuntu/debian/yocto/unknown from /etc/os-release
Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>
vnarapar
force-pushed
the
ubuntu_config_enable
branch
from
October 8, 2026 10:12
0c59856 to
8493b2e
Compare
Srikanth Muppandam (smuppand)
approved these changes
Oct 9, 2026
Srikanth Muppandam (smuppand)
merged commit Oct 9, 2026
1e69f7d
into
qualcomm-linux:main
14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_kernel_config() previously only read /proc/config.gz.