Repository navigation
ethernet: default basic connectivity ping to 8.8.8.8 - #614
Merged
Merged
Conversation
Use 8.8.8.8 instead of the discovered gateway when the basic Ethernet test has no ping-target override. Preserve PING_TARGET for an empty CLI value so empty LAVA parameters retain the runner default or environment selection. Document explicit local-peer overrides and external ICMP requirements. Keep the shared helper and other Ethernet suites unchanged. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Srikanth Muppandam (smuppand)
marked this pull request as ready for review
October 12, 2026 10:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The supplied stdout from LAVA job 478698 shows eth0 with IPv4 10.142.127.135 and passing link/IP checks. With an empty ping target, the test selected 10.142.126.1 and failed after three unanswered ping attempts. The existing selector prefers the interface gateway. This change makes the default destination explicit and predictable.