Repository navigation
AudioRecord: fix PipeWire capture timing and source selection - #619
Open
Srikanth Muppandam (smuppand) wants to merge 2 commits into
Open
Srikanth Muppandam (smuppand) wants to merge 2 commits into
Srikanth Muppandam (smuppand) wants to merge 2 commits into
Conversation
Separate PipeWire startup waiting from delivered WAV sample duration. Bound idle progress and total capture time, preserve explicit deadlines, and stop only the owned recorder with signal-safe cleanup. Reuse WAV header parsing without requiring Python, retain failure context for stdout replay, and reject failed recorder status even when partial samples validate. AudioRecord integration follows in a separate dependent commit. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Use the shared progress monitor in config discovery and legacy matrix modes. Select the discovered PipeWire target directly instead of relying on the session default, and remove size-only virtual-input fallbacks that can mask the requested route failure. Keep native ALSA and PulseAudio capture commands unchanged. Replay bounded recorder and source diagnostics on failure and document timing, timeout and cleanup behavior. Depends on the preceding shared audio helper commit. Revert this integration before reverting those helpers. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Srikanth Muppandam (smuppand)
force-pushed
the
audio-capture-progress
branch
from
October 15, 2026 05:42
2104756 to
7cee3cb
Compare
Srikanth Muppandam (smuppand)
marked this pull request as ready for review
October 15, 2026 17:50
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AudioRecord can stop PipeWire recording before enough samples arrive after a slow startup, and its implicit default input can differ from the discovered microphone. The LeMans short-capture failures also lacked recorder diagnostics in LAVA stdout.
Bind recording to the discovered source and use separate bounded startup and sample-progress windows. Preserve explicit timeout limits and final WAV validation, reject stalled or incomplete captures, and remove virtual-input fallbacks that can mask the selected route's failure. Print bounded recorder and source diagnostics on failure and preserve owned-child cleanup. Native ALSA and PulseAudio capture flows remain unchanged.