[AArch64] Fix TLSDESC_ADD_LO12 encoding#1379
Merged
Merged
Conversation
R_AARCH64_TLSDESC_ADD_LO12_NC applies to an ADD instruction whose immediate field takes an unshifted 12-bit page offset. Signed-off-by: Shankar Easwaran <seaswara@qti.qualcomm.com>
Shankar Easwaran (quic-seaswara)
requested a review
from Parth (parth-07)
as a code owner
Shankar Easwaran (quic-seaswara)
requested review from
Eli Friedman (efriedma-quic),
Parth (parth-07),
Alexey Karyakin (quic-akaryaki) and
quic-areg
and removed request for
Parth (parth-07)
Eli Friedman (efriedma-quic)
approved these changes
Jul 1, 2026
Eli Friedman (efriedma-quic)
left a comment
Eli Friedman (efriedma-quic)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Parth (parth-07)
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R_AARCH64_TLSDESC_ADD_LO12_NC applies to an ADD instruction whose immediate field takes an unshifted 12-bit page offset.