Enforce unique benchmark names - #8279
Closed
pavoljuhas wants to merge 1 commit into
Closed
Conversation
Benchmark results are stored in BigQuery under the pytest-benchmark function name rather than full ID. Here we ensure that future benchmarks will not use overlapping function name.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8279 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 1122 1122
Lines 102598 102598
=======================================
Hits 102182 102182
Misses 416 416 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
On another check, the BigQuery in fact stores full benchmark names. This is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark results are stored in BigQuery under the pytest function
name rather than a full pytest ID. Here we ensure that future
benchmarks will not add overlapping function names.