Skip to content

fix: CompactDataBlock.n_tiles() missing paper's +3 term (#1943) #1949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kkoci wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix: CompactDataBlock.n_tiles() missing paper's +3 term (#1943) #1949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qualtran/surface_code/data_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class CompactDataBlock(DataBlock):
data_d: int

def n_tiles(self, n_algo_qubits: int) -> int:
return math.ceil(1.5 * n_algo_qubits)
return math.ceil(1.5 * (n_algo_qubits + 2))

@property
def n_steps_to_consume_a_magic_state(self) -> int:
Expand Down
9 changes: 8 additions & 1 deletion qualtran/surface_code/data_block_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

import pytest

from qualtran.surface_code import FastDataBlock, LogicalErrorModel, QECScheme
from qualtran.surface_code import CompactDataBlock, FastDataBlock, LogicalErrorModel, QECScheme


@pytest.mark.parametrize(
Expand All @@ -28,3 +28,10 @@ def test_fast_block(logical_qubits, logical_qubits_with_routing, data_error):
assert FastDataBlock(3).data_error(
n_algo_qubits=logical_qubits, n_cycles=3, logical_error_model=err_model
) == pytest.approx(data_error)

@pytest.mark.parametrize(
["n_algo_qubits", "n_tiles"],
[[2,6],[4,9],[100,153]]
)
def test_compact_block(n_algo_qubits, n_tiles):
assert CompactDataBlock(data_d=17).n_tiles(n_algo_qubits=n_algo_qubits) == n_tiles