Skip to content

fix: move skip to global [tool.cibuildwheel] to fix validate-pyprojec… #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sun-9545sunoj wants to merge 2 commits into from
Closed

fix: move skip to global [tool.cibuildwheel] to fix validate-pyprojec… #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc5f3e8
fix: move skip to global [tool.cibuildwheel] to fix validate-pyprojec…
Jul 29, 2026
ef797e9
ci: fix Windows CMake build — use Ninja generator instead of NMake
Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
cancel-in-progress: true
group: ${{github.workflow}}-${{github.event.pull_request.number||github.ref}}

permissions: read-all

Check warning on line 56 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

excessive-permissions 

ci.yaml:56: overly broad permissions: uses read-all permissions

jobs:
python-checks:
Expand All @@ -67,7 +67,7 @@
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v5

Check warning on line 70 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

ci.yaml:70: action's hash pin has mismatched or missing version comment: points to commit a26af69be951
with:
python-version: ${{env.python-version}}
cache: pip
Expand Down Expand Up @@ -188,7 +188,7 @@

- name: Run actionlint
continue-on-error: ${{inputs.soft-linting == 'true'}}
uses: raven-actions/actionlint@205b530c5d9fa8f44ae9ed59f341a0db994aa6f8 # v2

Check warning on line 191 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

ci.yaml:191: action's hash pin has mismatched or missing version comment: points to commit 3d39aea43475
with:
flags: ${{inputs.debug && '-verbose'}}
files: '.github/workflows/*.{yaml,yml}'
Expand Down Expand Up @@ -226,7 +226,7 @@
submodules: recursive

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v5

Check warning on line 229 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

ci.yaml:229: action's hash pin has mismatched or missing version comment: points to commit a26af69be951
id: setup
with:
python-version: ${{matrix.python_version}}
Expand Down Expand Up @@ -260,8 +260,8 @@
env:
root: 'C:\\hostedtoolcache\\windows\\Python'
exe: '${{steps.setup.outputs.python-version}}\\x64\\python3.exe'
shell: cmd

Check warning on line 263 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

misfeature 

ci.yaml:263: usage of GitHub Actions misfeatures: shell defined here
run: bash -x dev_tools/test_libs.sh ${{inputs.debug && '--config=verbose'}} --action_env PYTHON_BIN_PATH=${{env.root}}\\${{env.exe}}

Check failure on line 264 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code

Check failure on line 264 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

template-injection 

ci.yaml:264: code injection via template expansion: may expand into attacker-controllable code

- name: Install LLVM and OpenMP on macOS
if: startsWith(matrix.os, 'macos')
Expand All @@ -286,8 +286,16 @@
export CXXFLAGS="-I${xcode_prefix}/usr/include -I${brew_prefix}/include -O3 -std=c++17 -flto=auto -Xpreprocessor -fopenmp"
echo "CXXFLAGS=${CXXFLAGS}" >> "$GITHUB_ENV"

- name: Set up MSVC developer environment (Windows only)
if: startsWith(matrix.os, 'windows-')
uses: microsoft/setup-msbuild@6fb02220983dee41ce7ae257b6f4d8f9bf5ed4ce # v2

- name: Build the Python bindings
shell: bash
env:
# Use Ninja on Windows: it is pre-installed on GitHub runners and does
# not require a Developer Command Prompt the way NMake does.
CMAKE_GENERATOR: ${{startsWith(matrix.os, 'windows-') && 'Ninja' || ''}}
run: |
mkdir -p build
cd build
Expand Down Expand Up @@ -318,7 +326,7 @@
submodules: recursive

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v5

Check warning on line 329 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

ci.yaml:329: action's hash pin has mismatched or missing version comment: points to commit a26af69be951
with:
python-version: ${{env.python-version}}
cache: pip
Expand Down Expand Up @@ -377,7 +385,7 @@
submodules: recursive

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v5

Check warning on line 388 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

ci.yaml:388: action's hash pin has mismatched or missing version comment: points to commit a26af69be951
with:
python-version: ${{env.python-version}}
cache: pip
Expand All @@ -404,13 +412,13 @@
- name: Run TCMalloc tests
env:
PERFTOOLS_VERBOSE: ${{inputs.debug && 1}}
run: bazel test --config=tcmalloc ${{env.common_args}}

Check failure on line 415 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code

Check failure on line 415 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

template-injection 

ci.yaml:415: code injection via template expansion: may expand into attacker-controllable code

- name: Run memory sanitizer tests
run: bazel test --config=msan ${{env.common_args}}

Check failure on line 418 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code

Check failure on line 418 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

template-injection 

ci.yaml:418: code injection via template expansion: may expand into attacker-controllable code

- name: Run address sanitizer tests
run: bazel test --config=asan ${{env.common_args}}

Check failure on line 421 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code

Check failure on line 421 in .github/workflows/ci.yaml

View workflow job for this annotation

GitHub Actions / zizmor-output

template-injection 

ci.yaml:421: code injection via template expansion: may expand into attacker-controllable code

docker-tests:
name: Docker build tests
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ dependencies = {file = ["requirements.txt"] }

[tool.cibuildwheel]
build = "cp310-* cp311-* cp312-* cp313-* cp314-*"
skip = "*musllinux*"
dependency-versions = "latest"
enable = ["cpython-prerelease"]
environment.PIP_PREFER_BINARY = "1"
Expand Down Expand Up @@ -157,7 +158,6 @@ delocate-wheel --verbose --require-archs {delocate_archs} -w {dest_dir} {wheel}
[tool.cibuildwheel.linux]
manylinux-x86_64-image = "manylinux2014"
manylinux-i686-image = "manylinux2014"
skip = "*musllinux*"

[tool.black]
target-version = ['py310', 'py311', 'py312', 'py313', 'py314']
Expand Down
Loading