Skip to content

Feature/qraffle asset#887

Open
double-k-3033 wants to merge 26 commits into
qubic:developfrom
double-k-3033:feature/qraffle-asset
Open

Feature/qraffle asset#887
double-k-3033 wants to merge 26 commits into
qubic:developfrom
double-k-3033:feature/qraffle-asset

Conversation

@double-k-3033

Copy link
Copy Markdown
Contributor

No description provided.

@double-k-3033 double-k-3033 force-pushed the feature/qraffle-asset branch 2 times, most recently from 425c843 to 5c4b6fe Compare May 28, 2026 03:39
@double-k-3033 double-k-3033 force-pushed the feature/qraffle-asset branch from 5c4b6fe to 85ee0d2 Compare May 28, 2026 03:56
@fnordspace

Copy link
Copy Markdown
Contributor

Please provide a description what the PR is changing to start the review process

@double-k-3033

Copy link
Copy Markdown
Contributor Author

Please provide a description what the PR is changing to start the review process

https://github.com/double-k-3033/QRaffle-asset-raffle-SC-proposal

@fnordspace fnordspace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Only concern is the state change which needs a migration tool or an explanation why not. Also would be helpful to provide information about how much bytes are needed to be padded to verify.

Comment thread src/contracts/QRaffle.h
@double-k-3033 double-k-3033 requested a review from fnordspace June 14, 2026 22:17
@Franziska-Mueller

Copy link
Copy Markdown
Collaborator

@double-k-3033 we have introduced state migration in core, please see the doc here: https://github.com/qubic/core/blob/develop/doc/contracts.md#state-change
please adapt your PR to do the state migration directly in your contract instead of the external migration tool. you have to merge the most recent version of the develop branch into your branch to get the required features.

@Franziska-Mueller Franziska-Mueller self-requested a review June 19, 2026 16:16
@double-k-3033 double-k-3033 force-pushed the feature/qraffle-asset branch from d1de23b to 517f85c Compare June 24, 2026 09:29
Comment thread src/contracts/QRaffle.h Outdated
@Franziska-Mueller

Copy link
Copy Markdown
Collaborator

please also add your requested state migration to the contractStateChangeInfos variable in contract_def.h as described in the documentation.

@double-k-3033 double-k-3033 force-pushed the feature/qraffle-asset branch from 517f85c to 68479e5 Compare June 24, 2026 14:21

@fnordspace fnordspace left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

One side note the proposal you send mentions: "No state migration is required: the new state fields are appended and start zeroed." which is not true anymore.

Besides that good to go from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants