Feature/qraffle asset#887
Conversation
425c843 to
5c4b6fe
Compare
5c4b6fe to
85ee0d2
Compare
|
Please provide a description what the PR is changing to start the review process |
https://github.com/double-k-3033/QRaffle-asset-raffle-SC-proposal |
fnordspace
left a comment
There was a problem hiding this comment.
Code changes look good to me. Only concern is the state change which needs a migration tool or an explanation why not. Also would be helpful to provide information about how much bytes are needed to be padded to verify.
|
@double-k-3033 we have introduced state migration in core, please see the doc here: https://github.com/qubic/core/blob/develop/doc/contracts.md#state-change |
d1de23b to
517f85c
Compare
|
please also add your requested state migration to the |
517f85c to
68479e5
Compare
fnordspace
left a comment
There was a problem hiding this comment.
Looks good to me.
One side note the proposal you send mentions: "No state migration is required: the new state fields are appended and start zeroed." which is not true anymore.
Besides that good to go from my side.
No description provided.