Add GGWP (WolfPack) contract commands to qubic-cli#125
Open
MZoxx wants to merge 3 commits into
Open
Conversation
Adds CLI support for the GGWP (WolfPack) revenue-distribution and
staking smart contract:
- Read: status, holder/clan/shareholder/staking info, exclude
info, distribution preview
- Admin: deposit revenue, add/remove clan member, set clan rank,
set admin, set exclude address
- Staking: stake, request/finalize unstake, deposit staking rewards,
claim staking rewards
New files ggwp.cpp / ggwp.h; command parsing in argparser.h, dispatch
in main.cpp, command enum in structs.h, globals in global.h, build
entry in CMakeLists.txt, and a [WOLFPACK COMMANDS] section in both the
-help output and README.md. Builds cleanly against current main.
Collaborator
|
@MZoxx Do you need to update this PR to adapt to the change in core ? |
WP_CONTRACT_INDEX was 27 (Escrow); the live WolfPack contract is index 28. Add WP_STAKE_FEE/WP_FINALIZE_FEE/WP_CLAIM_FEE constants for the contract-enforced invocation-reward fees.
wpStake/wpFinalizeUnstake/wpClaimStakingRewards sent invocationReward 0, which the contract rejects (INSUFFICIENT_FEE). Send 900/1000/100 QU respectively. Fix the stake LOG hint to newMgmtIdx 28.
| printf("\t\tShow WolfPack exclude addresses (slot 1 and slot 2).\n"); | ||
| printf("\t-ggwpdistpreview <AMOUNT>\n"); | ||
| printf("\t\tPreview distribution split for AMOUNT QU (calls WP fn 7).\n"); | ||
| printf("\t-ggwpdeposit <amount>\n"); |
Contributor
There was a problem hiding this comment.
nit: it would be consistent if you spelled AMOUNT all caps here, dito for some other parameters below (rank, slot,...)
| // ─── Input/Output structs ────────────────────────────────────── | ||
|
|
||
| // fn 1 – GetStatus | ||
| struct WPGetStatus_output |
Contributor
There was a problem hiding this comment.
we have core as a submodule in the cli, can you try to use the structs from core directly instead of duplicating them? (let me know if there are issues due to includes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CLI support for the GGWP (WolfPack) revenue-distribution and staking smart contract:
info, distribution preview
set admin, set exclude address
claim staking rewards