Support get revenue data from node.#126
Merged
Merged
Conversation
| } | ||
| } | ||
|
|
||
| // Mirrors core computeMultiDimRevenue in src/revenue.h |
Contributor
There was a problem hiding this comment.
we have core as a submodule in the cli so no need to duplicate the code
| }; | ||
| #pragma pack(pop) | ||
|
|
||
| // Mirrors core RespondRevenueData (src/network_messages/revenue_data.h). Wire format must match exactly. |
Contributor
There was a problem hiding this comment.
same here, you can directly use the struct from core (and we should refactor this for all structs currently used in the cli that were copied from core)
Contributor
|
Merging as is. Fixes will be implemented as separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow request an approximate revenue from node and output to a csv file.
Node only provide raw score factors, so the cli need to replicate the revenue at the tick.