Add finance Vercel deployment workflows#2
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/deploy, adapted fromcorp-web-japanbut parameterized withPROJECT_NAMEso each micro-site project can have its own workflow.Deploy Finance on Preview(.github/workflows/deploy-finance-on-preview.yml)Deploy Finance on Staging(.github/workflows/deploy-finance-on-staging.yml)Deploy Finance on Production(.github/workflows/deploy-finance-on-production.yml)apps/finance/vercel.jsonto mirror the sibling repo deployment model and disable automatic Vercel Git deployments because GitHub Actions owns deployment orchestration.README.mdand extend the structure test to cover the deploy setup.Verification
npm run test:cinpm ci --prefix scripts/deploynode --check scripts/deploy/index.jspython3 -m json.tool apps/finance/vercel.json >/dev/nullNotes
next buildprinted a workspace-root warning because the worktree lives under another checkout with its ownpackage-lock.json; the build still passed. A normal CI checkout should not have that nested-worktree layout.