Fix CMake config installation path to match package name

[qr243vbi]

The qjsConfig.cmake should be named as quickjsConfig.cmake instead, in order to match the package name and help CMake (the find_package(quickjs) command) find the requested library configuration.

[saghul]

What is this fixing?

[qr243vbi]

What is this fixing?

qjs not found error

[bnoordhuis]

Isn't that just you using the wrong path? Can you show what you tried to do in your own cmake files that errored?

[qr243vbi]

find_package(qjs CONFIG QUIET)

[saghul]

I guess this is because the target name is qjs and thus cmake generates that directory?

What would it take to change it to "quickjs" so projects do find_package(quickjs CONFIG QUIET)

instead?

[CarterLi]

@saghul sorry for a duplicate PR.

What would it take to change it to "quickjs" so projects do find_package(quickjs CONFIG QUIET)

find_package(%pkgname%) will search ${prefix}/lib/cmake/%pkgname%/%pkgname%Config.cmake

So if you do find_package(quickjs CONFIG QUIET), CMake will search ${prefix}/lib/cmake/quickjs/quickjsConfig.cmake, which doesn't exist either.

quickjs/CMakeLists.txt

Line 562 in 14892f8

install(EXPORT qjsConfig DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/quickjs)

This line will generate ${CMAKE_INSTALL_LIBDIR}/cmake/quickjs/qjsConfig.cmake, we must either change EXPORT qjsConfig to EXPORT quickjsConfig (find_package(quickjs) will work in this case), or change DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/quickjs to DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/qjs

[qr243vbi]

I guess this is because the target name is qjs and thus cmake generates that directory?

What would it take to change it to "quickjs" so projects do find_package(quickjs CONFIG QUIET)

instead?

No, that does not work. I tried both find_package(quickjs CONFIG QUIET) and find_package(qjs CONFIG QUIET), but neither works due to a bug in CMakeLists.txt of quickjs-ng. I renamed qjsConfig to quickjsConfig, which made find_package(quickjs CONFIG QUIET) work correctly.

[saghul]

I think keeping things as is (plus this PR) is the right thing to do now, otherwise everyone might need to adapt their CMake files.

We can reconsider that for 1.0 maybe.

EDIT: Nevermind, I mixed the 2 PRs. I'm landing this.