Remove legacy DataFusion service wrappers#6378
Draft
alexanderbianchi wants to merge 3 commits intoquickwit-oss:mainfrom
Draft
Remove legacy DataFusion service wrappers#6378alexanderbianchi wants to merge 3 commits intoquickwit-oss:mainfrom
alexanderbianchi wants to merge 3 commits intoquickwit-oss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6364. This is intentionally a cleanup/breaking PR that should merge only after Pomsky has moved to the unified
DataFusionService::execute(DataFusionRequest)API.Removes the legacy Rust service surface that #6364 kept for backwards compatibility:
SubstraitExecutionSubstraitExecutionMetadataexecute_substrait/execute_substrait_jsonexecute_substrait*_with_metadataexplain_substrait/explain_substrait_jsonexplain_substrait*_with_metadataexecute_sqlThe gRPC/proto
ExecuteSubstraitservice method and lower-levelDataFusionSessionBuilder::execute_substraitinternals are left intact. Protocol adapters should call the unifiedexecuteAPI directly.Validation
cargo +nightly fmt --all -- --checkcargo check -p quickwit-df-core --features grpccargo clippy -p quickwit-df-core --features grpc -- -D warnings