fix(settings): allow text selection in settings panel#122
Merged
quiet-node merged 1 commit intomainfrom May 2, 2026
Merged
Conversation
Signed-off-by: Logan Nguyen <lg.131.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user-select: noneon the root.windowand a drag handler whose interactive-tag opt-out missed text tags (<p>,<span>,<code>, headings). Click-and-drag on text moved the whole NSPanel instead of starting a selection, so users couldn't highlight or copy any text inside Settings.What changed
src/styles/settings.module.css:.bodyand.bannernow declareuser-select: text. The window-wideuser-select: noneon.windowstill applies to chrome.src/settings/SettingsWindow.tsxhandleDragStart:e.button !== 0so right/middle-click pass through cleanly.<div>,<section>) without their own text still drag, so empty regions and gaps preserve the "click anywhere blank to drag" feel.SettingsWindow.test.tsxcover the text-leaf no-drag path (banner<code>) and the non-primary-button no-drag path.Why this design
data-tauri-drag-region) preserves the existing fallback for nested form children, which the attribute can't handle reliably at the root.Test plan
bun run test:all:coverage— frontend + backend pass, coverage gate holds (100% lines/functions).bun run validate-build— lint, format, typecheck, build all clean.