Use quiet capture icons in the menu bar - #1669
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
record.circleinstead of a filled red recording symbol.waveforminstead of a red microphone.recording meetinganddictating.Why
The always-visible red status-item symbols were conspicuous when the user shared an entire display. Transcripted owns these icons, so the smallest fix is to keep distinct silhouettes while removing the baked-in red treatment.
Visuals
The visuals are synthetic and contain no transcript or audio content.
Validation
bash build-deps.sh --forcebash build.sh --no-openbash run-tests.sh --filter StatusItemPresentationTests— 6/6 passedbash run-tests.sh— 12,138/12,138 passedThe deterministic test pins both symbol mappings, their accessibility labels, template rendering, removal of the red status-item treatment, and runtime SF Symbol availability.
Proof boundary and manual QA
This change reduces unnecessary visual exposure when the macOS menu bar is included in a whole-display share. It does not hide the status item or suppress Apple's privacy indicators. Existing
NSWindow.sharingType = .noneassignments are defense-in-depth only and are not treated as captured-pixel proof.Still validate with synthetic text and no real transcript/audio content:
Independent review
codex review --base origin/mainexited 0 with no actionable findings. The reviewer rejected only a transient shared-build race caused by its own parallel build/test attempt; the required sequential rerun passedbash build.sh --no-openand all 12,138 fast tests.