Refine UploadSecurityExtractor to eliminate false positives#22
Refine UploadSecurityExtractor to eliminate false positives#22google-labs-jules[bot] wants to merge 1 commit into
Conversation
- Tighten `SERVE_FILE` and `KEY_FROM_NAME` regexes - Filter out valid `console.log` use cases for `mimetype` checks - Ensure SVG definitions don't falsely flag from explicit `Content-Type` overrides without upload validation logic - Add regression tests verifying 5 common false positive variants are fixed - Update docguard metrics correctly (324 -> 325 tests)
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Audited
upload_security.pyextractor against benign real-world idioms, discovering 5 classes of false positives (local stream reads, saving filename to DB without building keys, returning an SVG statically, loggingmimetype, and local backups). Refined regex constraints and extraction matching to completely eliminate FPs while preserving total efficacy on 100% of true-positive tests, successfully greeningdocguardmetrics and adding an accompanying regression test matrix.PR created automatically by Jules for task 1554129877881250681 started by @raccioly