Triage self-scan findings: Fix FPs, suppress noise, add Dockerfile healthcheck#23
Triage self-scan findings: Fix FPs, suppress noise, add Dockerfile healthcheck#23google-labs-jules[bot] wants to merge 1 commit into
Conversation
…althcheck - **True Positive**: Added a `HEALTHCHECK` directive to the `Dockerfile`. - **False Positives**: - `serve-no-nosniff`: Removed `streamObject` (an LLM streaming method) from `SERVE_FILE` regex in `upload_security.py`. - `redos`: Tightened regex string check to `\bf['\"]` to avoid matching `f'` inside `r"script-src[^;'\"]*'self'"` in `surface.py`. - `error-disclosure`: Tightened `NODE_ENV` check to `\.\b(?:stack|message)\b` so it matches properties instead of English prose in `surface.py`. - **Regression Tests**: Added regression tests for all the false positives in `test_pentest_regressions.py`. - **Noise**: Added entries to `.websec-ignore` to suppress `websec-validator`'s own security scanner implementation files and global header exposure logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes issues found by running
websec run .against thewebsec-validatorcodebase itself. It adds a true positiveHEALTHCHECKtoDockerfile, fixes regex false positives onstreamObject,redos, anderror-disclosure, adds missing regression tests totest_pentest_regressions.py, and adds justifications to.websec-ignorefor rules scanning themselves.PR created automatically by Jules for task 9333590086938497128 started by @raccioly