Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/containers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- "containers/dnsmasq/**"
- "containers/ironic-nautobot-client/**"
- "containers/ironic-vnc-container/**"
- "containers/shell-operator-ironic/**"
- "containers/openstack-sync-operator/**"
- "containers/understack-tests/**"
- "python/**"
Expand Down Expand Up @@ -44,8 +43,6 @@ jobs:
context_path: "./containers/ironic-vnc-container/"
prebuild_script: ./sync_from_upstream.sh
prebuild_script_working_dir: containers/ironic-vnc-container/
- name: shell-operator-ironic
target: prod
- name: openstack-sync-operator
target: prod
- name: nautobot
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ repos:
- id: component-docs-check
name: Component Docs Check
description: Ensure every ArgoCD Application template has a component docs page.
entry: python scripts/check-component-docs.py
entry: python3 scripts/check-component-docs.py

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this failing?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes In my local. Not allowing me to commit.

language: system
files: '^charts/argocd-understack/templates/application-.*\.yaml$|^docs/deploy-guide/components/.*\.md$'
- id: trufflehog
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
### Action required

Ironic runbooks are now reconciled by the `ironicRunbooks` hook in
`openstack-sync-operator`. The old `shell-operator-ironic` controller and its
runbook shell hooks have been removed.

Deploy the UnderStack ref that contains this hook and the deploy-repo changes
together. The hook must exist in the operator image before it is enabled.

### Deprecations and removals

- `components/ironic/runbook-operator/`
- `containers/shell-operator-ironic/`
- `components/ironic/runbook-crd/`

The `IronicRunbook` CRD now lives in
`components/openstack-sync-operator/crds/`. Example runbooks moved to
`components/openstack-sync-plugins/ironic-runbooks/examples/`.
2 changes: 0 additions & 2 deletions components/ironic/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ resources:
# less than ideal addition but necessary so that we can have the ironic.conf.d loading
# working due to the way the chart hardcodes the config-file parameter which then
# takes precedence over the directory
- ./runbook-crd
- ./runbook-operator
# Alerting
- pr-clean-failed-servers.yaml
- pr-resource-availability.yaml
154 changes: 0 additions & 154 deletions components/ironic/runbook-crd/README.md

This file was deleted.

Loading
Loading