Skip to content

feat(neutron-understack): Add/remove gateway: trunk-based VIF attach and cleanup PUC-1920 - #2256

Merged
cardoe merged 1 commit into
mainfrom
netdev_vif
Sep 2, 2026
Merged

feat(neutron-understack): Add/remove gateway: trunk-based VIF attach and cleanup PUC-1920#2256
cardoe merged 1 commit into
mainfrom
netdev_vif

Conversation

@nidzrai

@nidzrai nidzrai commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Add/remove gateway: trunk-based VIF attach and cleanup

What does this change do?

Upgrade impact

  • This change requires operator action to upgrade. If checked, add the
    upgrade-impact label and a release note: run scriv create from the
    repository root and describe the required action in the generated
    changelog.d/ file. See RELEASING.md.

@nidzrai nidzrai changed the title feat: Add/remove gateway: trunk-based VIF attach and cleanup PUC-1920 feat(neutron-understack): Add/remove gateway: trunk-based VIF attach and cleanup PUC-1920 Aug 27, 2026
@cardoe

cardoe commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Code review

Found 1 issue:

  1. Leftover PR-specific image tag left in place for neutron_server (this pattern was flagged as needing to be reverted before merge on a previous PR, feat: PUC-1758: remove physical_network fallback lookup #2145, which had the same issue)

neutron_server is pointed at ghcr.io/rackerlabs/understack/neutron:pr-2256 instead of the pinned release tag 2026.1. This looks like a leftover from spinning up this PR's own e2e-test image build rather than an intentional change, and would leave configs pointing at an ephemeral, non-reproducible PR image if merged as-is.

neutron_ovn_metadata: "ghcr.io/rackerlabs/understack/neutron:2026.1"
neutron_openvswitch_agent: "ghcr.io/rackerlabs/understack/neutron:2026.1"
neutron_server: "ghcr.io/rackerlabs/understack/neutron:pr-2256"
neutron_rpc_server: "ghcr.io/rackerlabs/understack/neutron:2026.1"
neutron_bagpipe_bgp: "ghcr.io/rackerlabs/understack/neutron:2026.1"

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@cardoe
cardoe added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit 0d42fd3 Sep 2, 2026
69 checks passed
@cardoe
cardoe deleted the netdev_vif branch September 2, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants