Add Edit menu so ⌘V/dictation work in Settings text fields

[dhilgaertner]

Closes #512

Problem

Text fields across the Settings screens couldn't accept a paste — ⌘V did nothing and dictation/voice insertion failed.

Root cause

setupMenu() in AppDelegate.swift built a custom NSApp.mainMenu containing only an App menu — no Edit menu. On macOS the standard cut:/copy:/paste:/selectAll:/undo selectors are registered and routed through the Edit menu's items; with no Edit menu, ⌘V in a plain SwiftUI TextField/TextEditor was silently dropped (dictation uses the same responder-chain path).

Fix

Add a standard Edit menu (Undo/Redo/Cut/Copy/Paste/Select All) wired to the first responder in setupMenu(). App-wide fix — restores cut/copy/paste/select-all/undo everywhere.

The terminal is unaffected: GhosttySurfaceView.performKeyEquivalent returns true for any Cmd/Ctrl key when the surface is focused, and in macOS the key window's view hierarchy receives performKeyEquivalent before the main menu — so a focused terminal intercepts ⌘V/⌘C before the Edit-menu item can fire.

Verification

• make app builds clean; full test suite passes (226 tests).
• Edit menu appears with Cut/Copy/Paste/Select All (+ Undo/Redo); ⌘V pastes in Settings fields; terminal paste still works.

🤖 Generated with Claude Code

[dgershman]

Code & Security Review

Critical Issues

None.

Security Review

Strengths:

• Pure UI/menu wiring. No input handling, IPC, network, or persistence changes — no new attack surface.
• Menu items use target = nil (via addItem(withTitle:action:keyEquivalent:)), which routes selectors through the first-responder chain. Standard Cocoa pattern; no privileged code paths added.
• App-wide fix with minimal blast radius — only adds a submenu to NSApp.mainMenu.

Concerns: None.

Code Quality

Strengths:

• Excellent in-code comment (AppDelegate.swift:1083–1087) explains the root cause, the fix, and why the terminal is unaffected, citing #512. Future maintainers won't have to reverse-engineer this.
• Verified the terminal-isn't-affected claim against Packages/CrowTerminal/Sources/CrowTerminal/GhosttySurfaceView.swift:255: performKeyEquivalent returns true for any Cmd/Ctrl keyDown while the surface is non-nil, so a focused terminal intercepts ⌘V/⌘C before the main menu sees them. ✅
• Redo correctly uses uppercase "Z" as the key equivalent, which auto-adds the shift modifier — matches the macOS HIG.
• Selector(("undo:")) / Selector(("redo:")) as string-based selectors is the standard Cocoa pattern for undo:/redo: (they aren't @objc on a concrete class — they're routed through the responder chain to whichever responder implements them, e.g. NSTextView via its UndoManager). Same approach Interface Builder emits.
• #selector(NSText.cut(_:)) / copy / paste / selectAll correctly target methods that any AppKit text responder implements; the responder chain handles dispatch.
• setupMenu() is invoked once from applicationDidFinishLaunching (AppDelegate.swift:1039), so no risk of duplicate menu items on re-entry.
• Hard-coded English titles ("Undo", "Cut", etc.) are consistent with the existing App menu items in the same function ("Restart Manager", "Hide Crow", "Quit Crow") — no localization regression.

Consider (Green, non-blocking):

• The standard macOS Edit menu typically also offers "Paste and Match Style" (⌘⇧⌥V) and a Find submenu. The minimum viable set here is fine for fixing the Settings paste bug; richer items can land as a follow-up if a use case appears.

Summary Table

Color	Meaning	Verdict effect
Red	Must fix	Request changes
Yellow	Should fix	Request changes
Green	Consider	Approve allowed

Recommendation: Approve — driven by [0 Red, 0 Yellow, 1 Green] findings.

---

🐦‍⬛ Reviewed by Crow via Claude Code