Settings: tag/token list editor for repo/label fields

[dhilgaertner]

Closes #513

What

Replaces the six comma-delimited TextFields in Settings with a reusable TokenListEditor — entries render as removable chips, you add by typing/pasting, and you delete items individually.

Fields converted (all already [String] in the model)

Field	View	Binding
Excluded Review Repos (global)	AutomationSettingsView	defaults.excludeReviewRepos
Ignored Labels	AutomationSettingsView	defaults.ignoreReviewLabels
Excluded Ticket Repos	AutomationSettingsView	defaults.excludeTicketRepos
Always Include Repos	WorkspaceFormView	workspace.alwaysInclude
Auto-Review Repos	WorkspaceFormView	workspace.autoReviewRepos
Excluded Review Repos (per-workspace)	WorkspaceFormView	workspace.excludeReviewRepos

Component (Packages/CrowUI/Sources/CrowUI/TokenListEditor.swift)

• public struct TokenListEditor: View bound to Binding<[String]>.
• Removable gold chips (borrows LinkChip's capsule styling) with an x button.
• Add via type/paste: commit on Return or a typed comma; a pasted a, b, c splits into three chips on commit.
• Backspace on an empty input removes the last chip (.onKeyPress(.delete) — TextField doesn't report backspace when empty).
• Trims, ignores empty, de-dupes (case-sensitive, exact).
• Chips wrap via a small FlowLayout (macOS 14 Layout protocol). Includes a #Preview.
• Pure, unit-tested TokenListEditor.adding(_:to:) helper.

No persistence/schema change

The model fields are already [String]; the CSV was only a text representation. The editor binds directly to the existing arrays, so existing comma-separated configs decode and render as chips with no migration. The per-field parseCSV/joined glue is removed.

Tests

swift test --package-path Packages/CrowUI passes, including a new @Suite("TokenListEditor.adding") covering trim, empty-ignore, comma-split, case-sensitive de-dupe, intra-commit de-dupe, order, and trailing-comma. make app builds clean.

Note: paste-to-add depends on #512 (Settings Edit-menu paste fix) for ⌘V to reach the field. Typing + comma/Return works regardless. Rebase on main if #512 lands first.

🤖 Generated with Claude Code

[dgershman]

Code & Security Review

Small, well-scoped UI refactor: 6 CSV TextFields replaced by a reusable TokenListEditor chip editor in AutomationSettingsView and WorkspaceFormView. The model fields were already [String], so there's no persistence change or migration to worry about.

Security Review

Strengths:

• No new persistence path, no new IPC, no new code-eval surface. Token strings are stored as-is and bound to existing [String] fields.
• Input is trimmed and exact-deduped on commit — no surprise quoting or escaping behavior.
• Wildcard semantics (owner/*) are interpreted by downstream consumers, not by this editor, so the editor itself adds no new injection surface.

Concerns:

• None.

Code Quality

Strengths:

• Pure TokenListEditor.adding(_:to:) cleanly separates split/trim/dedup logic from SwiftUI plumbing, and the new @Suite("TokenListEditor.adding") covers trim, empty-ignore, comma split, case-sensitive dedupe against existing + intra-commit, order preservation, and trailing comma.
• Backspace-on-empty-removes-last-chip is handled via .onKeyPress(.delete) because TextField doesn't emit a text change in that state — the inline comment (Packages/CrowUI/Sources/CrowUI/TokenListEditor.swift:91-93) calls out exactly that subtlety.
• AutomationSettingsView wires .onChange { onSave?() } on each token array so chip add/remove triggers a single config write (commit batches multi-token paste into one array mutation). WorkspaceFormView keeps the existing "save on form submit" pattern. Behavior matches the previous CSV fields.
• All six converted fields are listed in the PR description and match the diff; no leftover parseCSV/csvJoined references remain (verified via ripgrep).
• FlowLayout is a small, self-contained macOS 14 Layout impl with sensible single-row fallback when proposal.width is nil.

Greens (consider, not blocking):

• 🟢 ForEach(Array(tokens.enumerated()), id: \.offset) (TokenListEditor.swift:32) — offset-based identity means removing chip at index N visually morphs each subsequent chip's text rather than removing the deleted one. Since adding() guarantees uniqueness, id: \.element (or unzipping to ForEach(tokens, id: \.self) and deriving the index) would give stable identity and cleaner removal animations. Not a correctness bug — remove(at:) guards with tokens.indices.contains(index).
• 🟢 trimmingCharacters(in: .whitespaces) (TokenListEditor.swift:123) handles spaces/tabs but not newlines. TextField normally rejects newlines, so this is fine in practice, but .whitespacesAndNewlines would be slightly more paste-robust.
• 🟢 Typing comma is consumed by .onKeyPress(",") { … return .handled } (TokenListEditor.swift:87-90), so the comma never appears in the input field — intentional and documented, but mildly surprising for first-time users. A short caption hint (e.g., "Press Return or comma to add") would aid discoverability.
• 🟢 Could not run swift test --package-path Packages/CrowUI in this checkout — GhosttyKit.xcframework is missing a binary artifact (pre-existing environment issue, unrelated to this PR). Trusting the PR description's "tests pass" claim, which is consistent with the test code I read.

Summary Table

Color	Meaning	Verdict effect
Red	Must fix	Request changes
Yellow	Should fix	Request changes
Green	Consider	Approve allowed

Recommendation: Approve — driven by [0 Red, 0 Yellow, 4 Green] findings.

🐦‍⬛ Reviewed by Crow via Claude Code