Type checking, formatting and some more improvements - #4
Open
firetech wants to merge 20 commits into
Open
Conversation
Generate using `yt-dlp --cookies-from-browser [browser] --cookies cookies.txt`
RemoveOnStop removes the pipe on clean stop, but the unit would fail to start after an unclean shutdown.
* Make page title slightly less namedroppy. * Slim down page title and input widgets (above table).
Some refactoring to make type checking as useful as possible.
Including VS Code settings for automatic formatting of python files.
...by trying to convert them to YouTube links.
Useful for slow servers. Now uses POST for uploading links instead of sending them through WS, otherwise keeping track of status for such uploads would be hard.
This improves runtime validation and enables deserialization. (Also changed "skip" request from client to "cancel".)
With this enabled, restarting the server will not clear the queue, and it will even resume playing from the same position. (This is the main reason for switching to Pydantic.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyrighttype checking to all files and refactor to make typing as usable as possible (i.e. all data shuffled around is strictly typed, nothing isAny).blackandisort.pyproject.tomlanduv.lockfiles for keeping track of requirements.spotify_scraperandyoutube_search(if those libs are installed).