Repository navigation
Appearance: real host config reads and reviewed, owned host overrides - #515
Draft
raiseCatError wants to merge 2 commits into
Draft
raiseCatError wants to merge 2 commits into
raiseCatError wants to merge 2 commits into
Conversation
…overrides /appearance now reads Ghostty and Kitty opacity, blur and background from the actual configuration graph (Ghostty: every default root, then one include queue; Kitty: the first existing kitty.conf, includes in place) and reports unresolved or unsafe values instead of inventing them. Saving shows the exact change and writes only after Enter: an NMSh-owned fragment, one recorded include hook and an ownership ledger, with captured snapshots re-verified before each atomic write and NMSh's own writes rolled back on failure. R removes exactly the recorded hook, keeping later user lines on their own line even when the original lacked a final newline, and recovers when the hook is already gone. Setup refuses when a later include would override the managed values. Kitty gets the appearance adapter but not the Ghostty key-binding installer, so /keyboard keeps its guidance there. On macOS Kitty's config in Library/Preferences is used instead of creating a new XDG file that would shadow it. Refs #399
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #399
What changed
/appearancereads Ghostty and Kitty opacity, blur and background from the real configuration graph. Ghostty: every default root, then one include queue (per v1.4.0Config.zig). Kitty: the first existingkitty.conf(XDG, then~/Library/Preferences/kittyon macOS), includes in place. Unresolved theme values, dynamic includes and unsafe values are reported, not invented.Rremoves exactly the recorded hook. Later user lines stay on their own line, including when the original file had no final newline. Removal also recovers when the hook is already gone./keyboardkeeps its guidance on Kitty.Verification
git diff --checkpass.npm run verifyon the pre-review source: 4592 of 4608 pass. The 2 failures are live startup timeouts under machine load (absolutePathLivefish,ansiLiveRegion): the frontend wrote 0 bytes in 20 s. Each passes when rerun alone. The final review fixes touch only host-appearance files and were checked with the focused set.Needs human testing (NOT RUN)
/appearance, change opacity/blur/background, review withS, confirm with Enter, reload the host, then remove withR. Check that the config is byte-identical apart from the hook.~/Library/Preferences/kitty.