Repository navigation
test: report why the Mermaid console-isolation render fails - #523
Draft
raiseCatError wants to merge 1 commit into
Draft
raiseCatError wants to merge 1 commit into
raiseCatError wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnostic only, not a fix.
tests/browserConsoleChrome.test.ts("a reload starts a new document; NMSh's find world, web pages and the Mermaid renderer never report") fails intermittently on the hosted macOS runner, shard 1/3: #514 (run 40630147755), #516 (run 40656373289), #521 (run 40755036517) and #522 (run 40755117211). Every failure is the same boolean assertion at line 106 (result.ok || result.code === 'syntax'), after roughly 13–16 s. The assertion discards the renderer's result, so the logs can't tell a render timeout from a crash or a protocol failure.This change adds the renderer's
code: reason(and the Mermaid version) as the assertion message. What passes and fails is unchanged: same expression, request, 10 s deadline and cleanup.Not reproduced locally: with the pinned mermaid@12.2.0 bundle (integrity-checked like CI), 3/3 runs passed on
devand 3/3 on #516's head, plus 2/2 under full 8-core CPU load (1.1–1.4 s each). Leading hypothesis: the 10 s render deadline expires on the hosted runner. This is unproven, which is why this change exists.The next hosted failure will report the code and reason, and the follow-up fix targets that.