Repository navigation
Welcome: a key press keeps the native image instead of character art - #532
Draft
raiseCatError wants to merge 1 commit into
Draft
raiseCatError wants to merge 1 commit into
raiseCatError wants to merge 1 commit into
Conversation
Stopping playback (any key, scroll, resize, handover) used to repaint the welcome image as character art, even with Logo animation Off. Playback frames are still deleted at once; a still already on screen stays, and the next paint shows the still as a native image. The archived card stays portable character art as before.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #531 (
c3620236).Bug (reproduced in Kitty 0.49.2): any key press, scroll, resize or handover turned the native welcome image into character art for the rest of the session, even with Logo animation Off.
cancelMotion()setstill, released every upload, andframe()painted withcellsOnly = this.still. Introduced in8d625b28(#521 stack);devis not affected.Fix (
src/welcome/startup.ts):snapshot.still) stays portable character art as before.dispose()releases everything explicitly.Tests
tests/welcomeLogoAnimation.test.ts: "a key press keeps the native still…". It fails onc3620236and passes with the fix.tests/welcomePlayback.test.ts: after input, frames and timers are freed and playback can't restart, and the repaint shows one native still upload. Scrolling repaints immediately.tsc --noEmitis clean. The full suite is left to CI.Physical QA (disposable Kitty 0.49.2, private HOME and Kitty config, Auto graphics, this build):