parsers: stop Choice from looping on a nested choice parser - #26
Merged
Merged
Conversation
Flatten nested choice parsers in one pass. A choice is flattened when it is created, so expanding each nested unnamed choice once flattens the whole tree. The previous loop re-added parsers without rebinding the input array and never terminated, so any nested Choice ran out of memory. Keep a named nested choice as a single alternative so its name is not lost, and use the flattened list for values other than char and Unit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choiceflattens nested choices to avoid extra parser calls. The flattening loop appended parsers to a list without rebinding the input array, so a nestedChoicenever let the loop terminate:The fix expands nested unnamed choices in one pass. A choice is flattened when it is created, so one pass expands the whole tree.
A named nested choice stays a single alternative and keeps its name.