parsers: keep Choice alternatives in order - #27
Merged
Merged
Conversation
…sses Merge only contiguous runs of character class parsers and keep each merged parser in its place. Previously every character class was merged into one parser and moved to the front, so a later character class could win before an earlier alternative and consume only one character.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choicemerged every character class parser into a singleSetand inserted it at the front of the alternatives.The merged parser could then win before an earlier alternative and consume only one character.
L("==")is the first alternative and should match the whole input.