parsers: limit char-class repetition scanning to max - #28
Merged
Merged
Conversation
Limit the input span before scanning repeated character classes. Previously the entire matching prefix was scanned before the count was clamped to max, so even a single repetition could scan the whole input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Char-class repetition scanned the entire matching prefix before clamping the consumed count to
max. With a small limit and a long matching input, this performedO(n)scanning instead ofO(min(n, max)).For example,
Set("a").Repeat(1, 1)scanned all one million characters innew string('a', 1_000_000)despite consuming only one.Fix:
Parsing time no longer grows with the matching input beyond
max.