Fix react-query mutation typing for v5.90 - #63
Merged
Conversation
rametta
approved these changes
Oct 14, 2025
rametta
left a comment
Owner
There was a problem hiding this comment.
This is great, thanks for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix react-query mutation typing for v5.90
Summary
UseMutationOptionssignature from @tanstack/react-query (the fourth generic now representsonMutateresults; mutation callbacks receive an extra context argument).useRapiniMutationhelper so it forwards callback arguments transparently, removing hard-coded parameter lists and keeping future TanStack changes from breaking the wrapper.These changes are necessary for react-query versions v5.89.0 and newer, as mentioned in TanStack/query/ issue 9660:
v5.89.0: onError, onSuccess and onSettled signature change breaks existing code and were created with the help of an AI agent.
Testing