Bump for release of v1.3.2 - #113
Open
sbhuiyan-r7 wants to merge 1 commit into
Open
sbhuiyan-r7 wants to merge 1 commit into
sbhuiyan-r7 wants to merge 1 commit into
Conversation
Releases the LDAP result coercion fix from #112 (SNR-1383), which is on master but not yet published. Consumers install dap from Rubygems, so the fix does not reach them until a release exists: a Project Sonar tcp_ldap_636 study is still aborting on a single referral-returning host out of 22,482. Gemfile.lock's PATH self-reference is bumped alongside version.rb, matching the state the tree was in at the v1.3.1 release. Verified: gem builds as dap-1.3.2, full spec suite 130 examples / 0 failures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Bumps
VERSIONto1.3.2so the LDAP fix from #112 can be released.Why it is needed
#112 (internal ref: SNR-1383) is merged to
masterbut not published. Consumers installdapfrom Rubygems, so the fix does not reach them until a release exists —mastercurrently reads1.3.1, the latest tag isv1.3.1, and Rubygems' latest is1.3.1.The concrete impact: a Project Sonar
tcp_ldap_636study aborts its whole processing stage on a single referral-returning host out of 22,482, because an unserializable value escapes toOj.dump(..., mode: :strict)outside the filter'srescueand terminatesdapmid-stream. Two studies had to be recovered by hand-patching the gem inside running containers; those patches died with the containers, so the next scheduled runs will fail identically until a release lands.The diff
Two lines:
lib/dap/version.rb—1.3.1→1.3.2Gemfile.lock— thePATHself-reference (dap (1.3.1)→dap (1.3.2))The lock is included because at the
v1.3.1release (78ce38a)Gemfile.lockalready read1.3.1, so version and lock have been in step; bumping onlyversion.rbwould leave the tree inconsistent. No dependency versions are touched.Verification
gem build dap.gemspec→dap-1.3.2.gembuilds cleanly.Note for whoever runs
rake releasebundle execfails on Ruby 3.1 in this repo, so run the release on Ruby ≥ 3.2:Gemfile.lockpinsnokogiri (1.19.4), which requires Ruby>= 3.2, whiledap.gemspecdeclaresrequired_ruby_version = '>= 3.1'and theGemfilesaysruby '>= 3.1'. So the committed lock is unsatisfiable on the minimum supported Ruby. That is pre-existing and deliberately not addressed here to keep this a clean release commit — but it is worth a follow-up, since it also means the two nokogiri CVEs from #111 are not actually fixed for anyone installing on 3.1.🤖 Generated with Claude Code