RDBC-1111 Drop the Node.js nightly job from the node-latest workflow - #581
Merged
Conversation
actions/setup-node has no bare `nightly` alias: the spec is split on `-`, so a lone `nightly` is used verbatim as the semver range and never matches any build. The job has failed at setup-node on every run since the workflow was added, hidden behind `continue-on-error`. Keep the `latest` canary only and remove the `continue-on-error` that existed solely for the nightly job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.hibernatingrhinos.com/issue/RDBC-1111
Description
The
nightlyentry of thetests/node-latestmatrix has failed at theactions/setup-nodestep on every run since the workflow was added in #569 (RDBC-1095), with:continue-on-errorkept the runs green, so this never surfaced.Root cause:
actions/setup-nodehas no barenightlyalias. The version spec is split on-(splitVersionSpec), so for a lonenightlythere is no prerelease part and the spec is used verbatim as the semver range.semver.satisfies(version, "nightly")is alwaysfalse, so no build ever matches even though linux-x64 nightlies exist. Only<major>-nightly,<x.y.z>-nightlyand exact<x.y.z>-nightly<date><sha>specs are supported (see setup-nodedocs/advanced-usage.mdand__tests__/nightly-installer.test.ts).Change: remove
nightlyfrom the matrix and thecontinue-on-errorexpression that existed only for it; the workflow keeps the weeklylatestcanary. The remainingnightlyin the file isRAVENDB_BUILD_TYPE: nightly(RavenDB server build type), unrelated.An alternative was to resolve the newest nightly major in a pre-step and pass
<major>-nightlyto setup-node; it was verified locally against the nightly index but dropped in favor of removing the job, as requested in the issue.Type of change
x.y.z->x.y.z)Target branch and backports
v7.2,v7.1,v7.0,v6.0)NodeLatest.ymlexists only onv7.2)How risky is the change?
Backward compatibility
Server compatibility
Affected runtimes
Public API
src/index.ts(npm run check-exportspasses).package.jsonandCLIENT_VERSIONinsrc/Http/RequestExecutor.ts(sync / release PRs only)Documentation update
README.mdhas been updatedTesting by Contributor
[latest]; setup-node matching reproduced locally againstnodejs.org/download/nightly/index.json: barenightlymatches nothing,27-nightlyresolves)npm run lint,npm run build,npm run check-exportsandnpm run check-importspass locallyRAVENDB_TEST_SERVER_PATH/RAVENDB_SERVER_VERSION)Dependencies
Is there any existing behavior change of other features due to this change?