[Super Productivity] require access token - #30163
Conversation
|
Thank you for your contribution! 🎉 🔔 @pvnkmnk you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. 📋 Quick checkout commandsBRANCH="ext/super-productivity"
FORK_URL="https://github.com/xmok/raycast-extensions.git"
EXTENSION_NAME="super-productivity"
REPO_NAME="raycast-extensions"
git clone -n --depth=1 --filter=tree:0 -b $BRANCH $FORK_URL
cd $REPO_NAME
git sparse-checkout set --no-cone "extensions/$EXTENSION_NAME"
git checkout
cd "extensions/$EXTENSION_NAME"
npm install && npm run devWe're currently experiencing a high volume of incoming requests. As a result, the initial review may take up to 15 business days. |
Greptile SummaryThe PR requires a Super Productivity local API access token and attaches it to API requests as a Bearer credential.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "[Super Productivity] accessToken in test" | Re-trigger Greptile |
| try { | ||
| const res = await fetch(url, { | ||
| headers: { | ||
| Authorization: `Bearer ${accessToken}`, |
There was a problem hiding this comment.
Authentication header lacks test coverage
Every API operation now depends on the exact Authorization header, but the current preference mock supplies no accessToken and the fetch assertions accept any options object. An incorrect token value, header name, or authorization scheme can therefore pass CI while leaving every command unable to authenticate.
Prompt To Fix With AI
This is a comment left during a code review.
Path: extensions/super-productivity/src/api.ts
Line: 31
Comment:
**Authentication header lacks test coverage**
Every API operation now depends on the exact `Authorization` header, but the current preference mock supplies no `accessToken` and the fetch assertions accept any options object. An incorrect token value, header name, or authorization scheme can therefore pass CI while leaving every command unable to authenticate.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
Screencast
super-productivity-260812.mp4
Checklist
npm run buildand tested this distribution build in Raycastassetsfolder are used by the extension itselfREADMEare located outside the metadata folder if they were not generated with our metadata tool