Fix iOS 26 release tag trigger and version extraction - #147
Merged
Conversation
Contributor
Playwright test resultsDetails
|
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-147/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
Contributor
|
📊 Ionic 9 Playwright Test Report View the detailed Ionic 9 report: https://rdlabo-dev.github.io/ionic-theme-ios27/pr-147/ Ionic 8 runs against the same screenshots in a separate matrix job. View both results in the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iOS 26 release command creates
ios26-v*tags via.npmrc, but the workflow only acceptedv*, soios26-v9.2.0-0did not trigger npm publishing.Match
ios26-v*and strip that prefix when validating the package version. Update the README tag example. The main branch already correctly usesios27-v*and needs no change.Validation: confirmed the current branch configuration and verified
ios26-v9.2.0-0extracts to9.2.0-0; diff check passed. No release was published. Existing tags still contain their original workflow; this fix applies to newly created tags containing the change.