refactor: use renderable guard for menu item extras - #894
Conversation
|
@QDyanbing is attempting to deploy a commit to the afc163's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. Walkthrough本次变更升级 Changes菜单项 extra 渲染
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change standardizes how menu item extras are rendered and updates the minimum utility dependency version; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #894 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 26 26
Lines 735 735
Branches 205 204 -1
=======================================
Hits 733 733
Misses 2 2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
说明
isReactRenderable统一判断菜单项 extra 是否需要渲染0特殊判断,统一 ReactNode 展示语义@rc-component/util的最低版本提升到首次提供该 helper 的^1.13.0验证
npm run tscnpm run lintnpm test -- tests/Options.spec.tsx --runInBandSummary by CodeRabbit
extra)的渲染判断。