Repository navigation
Use any for untyped Object/Function in flow-typed and debugger-shell - #2069
Merged
Merged
Conversation
…shell Summary: X-link: react/react-native#59092 With `experimental.function_and_object_type_is_no_longer_any`, Flow resolves `Object` and `Function` to the builtin class types instead of `any`. These annotations relied on the old meaning, so they become `any`: - `cli-types`: the `CommandFunction<Object>` of `Command.func`. Commands with exact arg types no longer fit it. - `yargs`: the `command` handler, which gave handlers an `any` context. `js1 fox` handlers rely on it. - `debugger-shell`: `SettingsStore`'s default values, which are read by key. Changelog: [Internal] Differential Revision: D125303674
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125303674. |
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Oct 14, 2026
…shell (#59092) Summary: X-link: react/metro#2069 With `experimental.function_and_object_type_is_no_longer_any`, Flow resolves `Object` and `Function` to the builtin class types instead of `any`. These annotations relied on the old meaning, so they become `any`: - `cli-types`: the `CommandFunction<Object>` of `Command.func`. Commands with exact arg types no longer fit it. - `yargs`: the `command` handler, which gave handlers an `any` context. `js1 fox` handlers rely on it. - `debugger-shell`: `SettingsStore`'s default values, which are read by key. Changelog: [Internal] Differential Revision: D125303674
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Oct 14, 2026
…shell (#59092) Summary: X-link: react/metro#2069 Pull Request resolved: #59092 With `experimental.function_and_object_type_is_no_longer_any`, Flow resolves `Object` and `Function` to the builtin class types instead of `any`. These annotations relied on the old meaning, so they become `any`: - `cli-types`: the `CommandFunction<Object>` of `Command.func`. Commands with exact arg types no longer fit it. - `yargs`: the `command` handler, which gave handlers an `any` context. `js1 fox` handlers rely on it. - `debugger-shell`: `SettingsStore`'s default values, which are read by key. Changelog: [Internal] Reviewed By: gkz Differential Revision: D125303674 fbshipit-source-id: 042b5ef6f84dc3d10190d14a4239b8f4cff7cadc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: react/react-native#59092
With
experimental.function_and_object_type_is_no_longer_any, Flow resolvesObjectandFunctionto the builtin class types instead ofany. These annotations relied on the old meaning, so they becomeany:cli-types: theCommandFunction<Object>ofCommand.func. Commands with exact arg types no longer fit it.yargs: thecommandhandler, which gave handlers ananycontext.js1 foxhandlers rely on it.debugger-shell:SettingsStore's default values, which are read by key.Changelog: [Internal]
Differential Revision: D125303674