Cover react/renderer/core with stable API guards (#58374) - #58374
Closed
j-piasecki wants to merge 1 commit into
Closed
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119065020. |
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 9, 2026 12:46
009a523 to
96d5116
Compare
meta-codesync
Bot
changed the title
react/renderer/core with stable API guardsreact/renderer/core with stable API guards (#58374)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules Differential Revision: D119065020
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 11, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
2 times, most recently
from
September 11, 2026 09:31
91fe81f to
098eda3
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 11, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` and `react/renderer/core:rawValue` as public targets under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the modules' 50 exported headers and introduces the module umbrellas `React/RendererCore.h` and `React/RawValue.h`, wiring the guard dependency into BUCK and CMake and the umbrellas into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the modules' headers directly, and should include `<React/RendererCore.h>` or `<React/RawValue.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added umbrella headers for `react/renderer/core:core` and `react/renderer/core:rawValue` modules Differential Revision: D119065020
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 14, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 50 exported headers and introduces the module umbrella `React/RendererCore.h`, wiring the guard dependency into BUCK and CMake and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. The Apple-only `rawValue` target also exports `RawValue.h` and `RawPropsPrimitives.h`, so it picks up the guard dependency as well, but it gets no umbrella of its own. Its only consumers are `core` and `react/renderer/graphics` — both React Native's own targets, which define `RN_BUILDING` and so see the guards as inert. Outside Buck there is no `rawValue` module at all: CocoaPods, CMake and the Android prefab ship a single `core`, and `React/RendererCore.h` already re-exports both headers. A second umbrella would have published a Buck-internal cycle-breaker as a public entry point with no callers. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RendererCore.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added an umbrella header for the `react/renderer/core` module Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 14, 2026 09:33
098eda3 to
6a298c2
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 14, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 50 exported headers and introduces the module umbrella `React/RendererCore.h`, wiring the guard dependency into BUCK and CMake and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. The Apple-only `rawValue` target also exports `RawValue.h` and `RawPropsPrimitives.h`, so it picks up the guard dependency as well, but it gets no umbrella of its own. Its only consumers are `core` and `react/renderer/graphics` — both React Native's own targets, which define `RN_BUILDING` and so see the guards as inert. Outside Buck there is no `rawValue` module at all: CocoaPods, CMake and the Android prefab ship a single `core`, and `React/RendererCore.h` already re-exports both headers. A second umbrella would have published a Buck-internal cycle-breaker as a public entry point with no callers. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RendererCore.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added an umbrella header for the `react/renderer/core` module Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 14, 2026 13:06
6a298c2 to
459895e
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 14, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 50 exported headers and introduces the module umbrella `React/RendererCore.h`, wiring the guard dependency into BUCK and CMake and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. The Apple-only `rawValue` target also exports `RawValue.h` and `RawPropsPrimitives.h`, so it picks up the guard dependency as well, but it gets no umbrella of its own. Its only consumers are `core` and `react/renderer/graphics` — both React Native's own targets, which define `RN_BUILDING` and so see the guards as inert. Outside Buck there is no `rawValue` module at all: CocoaPods, CMake and the Android prefab ship a single `core`, and `React/RendererCore.h` already re-exports both headers. A second umbrella would have published a Buck-internal cycle-breaker as a public entry point with no callers. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RendererCore.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added an umbrella header for the `react/renderer/core` module Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
2 times, most recently
from
September 15, 2026 08:23
1dfe28c to
e34d429
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 15, 2026
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 50 exported headers and introduces the module umbrella `React/RendererCore.h`, wiring the guard dependency into BUCK and CMake and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. The Apple-only `rawValue` target also exports `RawValue.h` and `RawPropsPrimitives.h`, so it picks up the guard dependency as well, but it gets no umbrella of its own. Its only consumers are `core` and `react/renderer/graphics` — both React Native's own targets, which define `RN_BUILDING` and so see the guards as inert. Outside Buck there is no `rawValue` module at all: CocoaPods, CMake and the Android prefab ship a single `core`, and `React/RendererCore.h` already re-exports both headers. A second umbrella would have published a Buck-internal cycle-breaker as a public entry point with no callers. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RendererCore.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added an umbrella header for the `react/renderer/core` module Differential Revision: D119065020
Summary: Pull Request resolved: react#58374 Classifies `react/renderer/core:core` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 50 exported headers and introduces the module umbrella `React/RendererCore.h`, wiring the guard dependency into BUCK and CMake and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. The Apple-only `rawValue` target also exports `RawValue.h` and `RawPropsPrimitives.h`, so it picks up the guard dependency as well, but it gets no umbrella of its own. Its only consumers are `core` and `react/renderer/graphics` — both React Native's own targets, which define `RN_BUILDING` and so see the guards as inert. Outside Buck there is no `rawValue` module at all: CocoaPods, CMake and the Android prefab ship a single `core`, and `React/RendererCore.h` already re-exports both headers. A second umbrella would have published a Buck-internal cycle-breaker as a public entry point with no callers. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/RendererCore.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [General][Added] - Added an umbrella header for the `react/renderer/core` module Differential Revision: D119065020
j-piasecki
force-pushed
the
export-D119065020
branch
from
September 15, 2026 08:27
e34d429 to
2723153
Compare
|
This pull request has been merged in dcc872a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/core:coreas a public target under the C++ stable API three-tier visibility model. Adds#include <react/cxxstableapi/UmbrellaGuard.h>to the module's 50 exported headers and introduces the module umbrellaReact/RendererCore.h, wiring the guard dependency into BUCK and CMake and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export.The Apple-only
rawValuetarget also exportsRawValue.handRawPropsPrimitives.h, so it picks up the guard dependency as well, but it gets no umbrella of its own. Its only consumers arecoreandreact/renderer/graphics— both React Native's own targets, which defineRN_BUILDINGand so see the guards as inert. Outside Buck there is norawValuemodule at all: CocoaPods, CMake and the Android prefab ship a singlecore, andReact/RendererCore.halready re-exports both headers. A second umbrella would have published a Buck-internal cycle-breaker as a public entry point with no callers.Consumers that opt into
RN_STRICT_APInow get an error if they include the module's headers directly, and should include<React/RendererCore.h>instead; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [General][Added] - Added an umbrella header for the
react/renderer/coremoduleDifferential Revision: D119065020