Extract out core components from auto-generated registry#51860
Closed
arushikesarwani94 wants to merge 2 commits into
Closed
Extract out core components from auto-generated registry#51860arushikesarwani94 wants to merge 2 commits into
arushikesarwani94 wants to merge 2 commits into
Conversation
…rated registry (react#51830) Summary: In order to avoid duplicates, extracting out the UnimplementedNativeViewComponentDescriptor from the auto-generated registry of FAC i.e. ComponentDescriptors.cpp All of the existing FAC apps already get it via DefaultComponentsRegistry **Changelog**: [Android] [Fixed] - Extract out `UnimplementedNativeViewComponentDescriptor` from auto-generated registry for FAC Reviewed By: RSNara Differential Revision: D76013507
Summary: In order to avoid duplicates, extracting out the core components from the auto-generated registry of FAC i.e. ComponentDescriptors.cpp All of the existing FAC apps already get it via DefaultComponentsRegistry -> CoreComponentsRegistry **Changelog**: [Android] [Fixed] - Extract out core components from auto-generated registry for FAC Differential Revision: D76078460
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76078460 |
Collaborator
|
This PR is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label. |
react-native-bot
added
Stale
Collaborator
|
Closing this PR as the diff D76078460 has been abandoned internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
In order to avoid duplicates, extracting out the core components from the auto-generated registry of FAC i.e. ComponentDescriptors.cpp
All of the existing FAC apps already get it via DefaultComponentsRegistry -> CoreComponentsRegistry
Changelog:
[Android] [Fixed] - Extract out core components from auto-generated registry for FAC
Differential Revision: D76078460