fixed error previews in console not presenting error class names#53064
Closed
vzaidman wants to merge 1 commit into
Closed
fixed error previews in console not presenting error class names#53064vzaidman wants to merge 1 commit into
vzaidman wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79451147 |
vzaidman
force-pushed
the
export-D79451147
branch
from
34f7866 to
9d7d2f2
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79451147 |
vzaidman
force-pushed
the
export-D79451147
branch
from
9d7d2f2 to
62cfb46
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79451147 |
vzaidman
force-pushed
the
export-D79451147
branch
from
62cfb46 to
ad4774a
Compare
vzaidman
force-pushed
the
export-D79451147
branch
from
ad4774a to
0ee5ac6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D79451147 |
vzaidman
force-pushed
the
export-D79451147
branch
from
0ee5ac6 to
9e2d5ea
Compare
…ct#53064) Summary: With {D75080385} pushed, we now report raw errors to the console much more often. This diff ensures that error previews are [in parity with V8](https://source.chromium.org/chromium/chromium/src/+/main:v8/src/inspector/value-mirror.cc;l=252-311;drc=bdc48d1b1312cc40c00282efb1c9c5f41dcdca9a), making them more readable. Changelog: [General][Fixed] error class names are now reflected correctly in error previews in React Native DevTools console Differential Revision: D79451147
vzaidman
force-pushed
the
export-D79451147
branch
from
9e2d5ea to
b422900
Compare
meta-codesync Bot
pushed a commit
to facebook/hermes
that referenced
this pull request
Feb 18, 2026
Summary: X-link: react/react-native#53064 With {D75080385} pushed, we now report raw errors to the console much more often. This diff ensures that error previews are [in parity with V8](https://source.chromium.org/chromium/chromium/src/+/main:v8/src/inspector/value-mirror.cc;l=252-311;drc=bdc48d1b1312cc40c00282efb1c9c5f41dcdca9a), making them more readable. Changelog: [General][Fixed] error class names are now reflected correctly in error previews in React Native DevTools console Reviewed By: fbmal7 Differential Revision: D79451147 fbshipit-source-id: 22993fb680a64fb578a6eb0740d3556039569d09
Collaborator
|
Closing as this PR is no longer needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
With {D75080385} pushed, we now report raw errors to the console much more often.
This diff ensures that error previews are in parity with V8, making them more readable.
Changelog: [General][Fixed] error class names are now reflected correctly in error previews in React Native DevTools console
Differential Revision: D79451147