Make TurboModuleBinding constructor private#54970
Closed
RSNara wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
RSNara
force-pushed
the
export-D89751218
branch
from
2498b04 to
3e612bd
Compare
Summary: The TurboModuleBinding constructor actually doesn't need to be public! It's only called from BridgelessTurboModuleProxy or TurboModuleBinding::install. Changelog: [General][Breaking] Make the TurboModuleBinding constructor private. Reviewed By: christophpurrer Differential Revision: D89751218
RSNara
force-pushed
the
export-D89751218
branch
from
3e612bd to
3740c94
Compare
Collaborator
|
Closing as this has been merged in 53944ea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The TurboModuleBinding constructor actually doesn't need to be private! It's only called from BridgelessTurboModuleProxy or TurboModuleBinding::install.
Changelog: [Internal]
Differential Revision: D89751218