Transform $Keys to keyof#55111
Closed
marcoww6 wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
marcoww6
force-pushed
the
export-D90426061
branch
from
81f01a1 to
7d96160
Compare
marcoww6
force-pushed
the
export-D90426061
branch
from
7d96160 to
0882519
Compare
marcoww6
force-pushed
the
export-D90426061
branch
from
0882519 to
a8984b7
Compare
Differential Revision: D90425806
Summary: Pull Request resolved: react#55111 We are transforming the following utility types to be more consistent with typescript and better AI integration: * `$NonMaybeType` -> `NonNullable` * `$ReadOnly` -> `Readonly` * `$ReadOnlyArray` -> `ReadonlyArray` * `$ReadOnlyMap` -> `ReadonlyMap` * `$ReadOnlySet` -> `ReadonlySet` * `$Keys` -> `keyof` * `$Values` -> `Values` * `mixed` -> `unknown` See details in https://fb.workplace.com/groups/flowlang/permalink/1837907750148213/. drop-conflicts Command: `js1 flow-runner codemod flow/transformUtilityType --format-files=false --legacy-type='$Keys'` Reviewed By: SamChou19815 Differential Revision: D90426061
marcoww6
force-pushed
the
export-D90426061
branch
from
a8984b7 to
b05ca0b
Compare
Collaborator
|
Closing this PR as the diff D90426061 has been abandoned internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We are transforming the following utility types to be more consistent with typescript and better AI integration:
$NonMaybeType->NonNullable$ReadOnly->Readonly$ReadOnlyArray->ReadonlyArray$ReadOnlyMap->ReadonlyMap$ReadOnlySet->ReadonlySet$Keys->keyof$Values->Valuesmixed->unknownSee details in https://fb.workplace.com/groups/flowlang/permalink/1837907750148213/.
drop-conflicts
Command:
js1 flow-runner codemod flow/transformUtilityType --format-files=false --legacy-type='$ReadOnlySet'Reviewed By: SamChou19815
Differential Revision: D90426061