Skip to content

[General] [Fixed] - Fix URLSearchParams.keys() returning only unique keys #56361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Nedunchezhiyan-M wants to merge 1 commit into from
Closed

[General] [Fixed] - Fix URLSearchParams.keys() returning only unique keys #56361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/react-native/Libraries/Blob/URLSearchParams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,14 @@ export class URLSearchParams {
}

keys(): Iterator<string> {
return this._searchParams.keys();
function* generateKeys(params: Map<string, string[]>): Iterator<string> {
for (const [key, values] of params) {
for (let i = 0; i < values.length; i++) {
yield key;
}
}
}
return generateKeys(this._searchParams);
}

values(): Iterator<string> {
Expand Down
4 changes: 4 additions & 0 deletions packages/react-native/Libraries/Blob/__tests__/URL-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,10 @@ describe('URL', function () {
expect(paramsFromArray.getAll('key1')).toEqual(['value1', 'value2']);
expect(paramsFromArray.get('key2')).toBe('value3');

// keys() should yield one entry per name-value pair, including duplicates
const keysArray = Array.from(paramsFromArray.keys());
expect(keysArray).toEqual(['key1', 'key1', 'key2']);

// Manipulating existing search params in the URL
const urlParams = url.searchParams;
expect(urlParams.get('query')).toBe('testQuery');
Expand Down