Deprecate legacy UIBlock and addUIBlock/prependUIBlock APIs#56827
Closed
cortinico wants to merge 2 commits into
Closed
Deprecate legacy UIBlock and addUIBlock/prependUIBlock APIs#56827cortinico wants to merge 2 commits into
cortinico wants to merge 2 commits into
Conversation
Summary: This class was fully stubbed out as part of the Legacy Architecture removal. All public methods had empty bodies or returned null/0, meaning any OSS library still referencing it was already silently broken at runtime. - `UIImplementation` — all methods empty stubs Also removes the dead `getUIImplementation()` method from `UIManagerModule`, and cleans up stale Javadoc references in `JSTouchDispatcher`, `ReactViewGroup`, and `ReactInterceptingViewGroup`. `UIBlock`, `NativeViewHierarchyManager`, `UIViewOperationQueue`, and the `addUIBlock`/`prependUIBlock` methods on `UIManagerModule` are retained and will be deprecated in a follow-up diff. Changelog: [Android][Removed] - Remove legacy architecture stub `UIImplementation`. This class was already non-functional (all methods were empty stubs). Differential Revision: D104991922
Summary: Deprecate `UIBlock`, `NativeViewHierarchyManager`, and the `addUIBlock`/`prependUIBlock` methods on `UIManagerModule`. These are legacy Paper architecture APIs that are already non-functional stubs. Libraries should migrate to `UIManagerListener` or View Commands. The Fabric replacement for `UIBlock` already exists at `com.facebook.react.fabric.interop.UIBlock` and uses `UIBlockViewResolver` instead of `NativeViewHierarchyManager`. Changelog: [Android][Deprecated] - Deprecate `UIBlock` interface and `UIManagerModule.addUIBlock`/`prependUIBlock` methods. Use `UIManagerListener` or View Commands instead. Differential Revision: D104995161
meta-cla
Bot
added
the
CLA Signed
Collaborator
|
Closing as this has been merged in 29a7691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Deprecate
UIBlock,NativeViewHierarchyManager, and theaddUIBlock/prependUIBlockmethods onUIManagerModule. These are legacy Paper architecture APIs that are already non-functional stubs. Libraries should migrate toUIManagerListeneror View Commands.The Fabric replacement for
UIBlockalready exists atcom.facebook.react.fabric.interop.UIBlockand usesUIBlockViewResolverinstead ofNativeViewHierarchyManager.Changelog:
[Android][Deprecated] - Deprecate
UIBlockinterface andUIManagerModule.addUIBlock/prependUIBlockmethods. UseUIManagerListeneror View Commands instead.Differential Revision: D104995161