Skip to content

RNTester / RCTReactNativeFactory remove unused new architecture flags and RCTArchConfiguratorProtocol (#57054) #57054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
christophpurrer wants to merge 1 commit into from
Closed

RNTester / RCTReactNativeFactory remove unused new architecture flags and RCTArchConfiguratorProtocol (#57054) #57054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions packages/react-native/Libraries/AppDelegate/RCTArchConfiguratorProtocol.h
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
#import <React/RCTBridgeDelegate.h>
#import <React/RCTConvert.h>
#import <UIKit/UIKit.h>
#import "RCTArchConfiguratorProtocol.h"
#import "RCTDependencyProvider.h"
#import "RCTJSRuntimeConfiguratorProtocol.h"
#import "RCTRootViewFactory.h"
Expand Down Expand Up @@ -39,8 +38,7 @@ typedef NS_ENUM(NSInteger, RCTReleaseLevel) { Canary, Experimental, Stable };
RCTTurboModuleManagerDelegate,
RCTComponentViewFactoryComponentProvider,
#endif
RCTJSRuntimeConfiguratorProtocol,
RCTArchConfiguratorProtocol>
RCTJSRuntimeConfiguratorProtocol>

/// Return the bundle URL for the main bundle.
- (NSURL *__nullable)bundleURL;
Expand Down
22 changes: 0 additions & 22 deletions packages/react-native/Libraries/AppDelegate/RCTReactNativeFactory.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,28 +132,6 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory
return [_delegate createJSRuntimeFactory];
}

#pragma mark - RCTArchConfiguratorProtocol

- (BOOL)newArchEnabled
{
return YES;
}

- (BOOL)fabricEnabled
{
return YES;
}

- (BOOL)turboModuleEnabled
{
return YES;
}

- (BOOL)bridgelessEnabled
{
return YES;
}

#pragma mark - RCTTurboModuleManagerDelegate

- (Class)getModuleClassFromName:(const char *)name
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/scripts/ios-prebuild/templates/React_RCTAppDelegate-umbrella.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

#import "RCTAppDelegate.h"
#import "RCTAppSetupUtils.h"
#import "RCTArchConfiguratorProtocol.h"
#import "RCTDefaultReactNativeFactoryDelegate.h"
#import "RCTDependencyProvider.h"
#import "RCTJSRuntimeConfiguratorProtocol.h"
Expand Down
7 changes: 0 additions & 7 deletions packages/rn-tester/RNTester/AppDelegate.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,13 +159,6 @@ - (void)userNotificationCenter:(UNUserNotificationCenter *)center
}
#endif

#pragma mark - New Arch Enabled settings

- (BOOL)bridgelessEnabled
{
return YES;
}

#pragma mark - RCTComponentViewFactoryComponentProvider

#ifndef RN_DISABLE_OSS_PLUGIN_HEADER
Expand Down
9 changes: 1 addition & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2608,13 +2608,6 @@ protocol RCTAnimationDriver : public NSObject {
public virtual void stopAnimation();
}

protocol RCTArchConfiguratorProtocol {
public virtual BOOL bridgelessEnabled();
public virtual BOOL fabricEnabled();
public virtual BOOL newArchEnabled();
public virtual BOOL turboModuleEnabled();
}

protocol RCTAutoInsetsProtocol {
public @property (assign) BOOL automaticallyAdjustContentInsets;
public @property (assign) UIEdgeInsets contentInset;
Expand Down Expand Up @@ -2985,7 +2978,7 @@ protocol RCTPullToRefreshViewViewProtocol : public NSObject {
public virtual void setNativeRefreshing:(BOOL refreshing);
}

protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol, public RCTArchConfiguratorProtocol {
protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol {
public @property (strong) id<RCTDependencyProvider> dependencyProvider;
public virtual NSDictionary<NSString*, Class<RCTComponentViewProtocol>>* thirdPartyFabricComponents();
public virtual NSURL* _Nullable bundleURL();
Expand Down
9 changes: 1 addition & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2596,13 +2596,6 @@ protocol RCTAnimationDriver : public NSObject {
public virtual void stopAnimation();
}

protocol RCTArchConfiguratorProtocol {
public virtual BOOL bridgelessEnabled();
public virtual BOOL fabricEnabled();
public virtual BOOL newArchEnabled();
public virtual BOOL turboModuleEnabled();
}

protocol RCTAutoInsetsProtocol {
public @property (assign) BOOL automaticallyAdjustContentInsets;
public @property (assign) UIEdgeInsets contentInset;
Expand Down Expand Up @@ -2972,7 +2965,7 @@ protocol RCTPullToRefreshViewViewProtocol : public NSObject {
public virtual void setNativeRefreshing:(BOOL refreshing);
}

protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol, public RCTArchConfiguratorProtocol {
protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol {
public @property (strong) id<RCTDependencyProvider> dependencyProvider;
public virtual NSDictionary<NSString*, Class<RCTComponentViewProtocol>>* thirdPartyFabricComponents();
public virtual NSURL* _Nullable bundleURL();
Expand Down
9 changes: 1 addition & 8 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2608,13 +2608,6 @@ protocol RCTAnimationDriver : public NSObject {
public virtual void stopAnimation();
}

protocol RCTArchConfiguratorProtocol {
public virtual BOOL bridgelessEnabled();
public virtual BOOL fabricEnabled();
public virtual BOOL newArchEnabled();
public virtual BOOL turboModuleEnabled();
}

protocol RCTAutoInsetsProtocol {
public @property (assign) BOOL automaticallyAdjustContentInsets;
public @property (assign) UIEdgeInsets contentInset;
Expand Down Expand Up @@ -2985,7 +2978,7 @@ protocol RCTPullToRefreshViewViewProtocol : public NSObject {
public virtual void setNativeRefreshing:(BOOL refreshing);
}

protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol, public RCTArchConfiguratorProtocol {
protocol RCTReactNativeFactoryDelegate : public RCTBridgeDelegate, public RCTUIConfiguratorProtocol, public RCTHostDelegate, public RCTTurboModuleManagerDelegate, public RCTComponentViewFactoryComponentProvider, public RCTJSRuntimeConfiguratorProtocol {
public @property (strong) id<RCTDependencyProvider> dependencyProvider;
public virtual NSDictionary<NSString*, Class<RCTComponentViewProtocol>>* thirdPartyFabricComponents();
public virtual NSURL* _Nullable bundleURL();
Expand Down
Loading