Use umbrellas instead of direct includes in react/runtime module - #58550
Open
j-piasecki wants to merge 6 commits into
Open
j-piasecki wants to merge 6 commits into
j-piasecki wants to merge 6 commits into
Conversation
j-piasecki
force-pushed
the
export-D120316197
branch
from
September 16, 2026 08:35
40b7b71 to
977bca6
Compare
meta-cla
Bot
added
the
CLA Signed
j-piasecki
force-pushed
the
export-D120316197
branch
2 times, most recently
from
September 21, 2026 06:43
309779a to
e11ff37
Compare
Summary: Each module ships a small header that acts as its entry point. Those were being packaged into the React framework, but the code that includes them lives in the shared headers bundle the framework is built on top of. The two ended up pointing at each other and the iOS build failed. Ship the entry-point headers with the shared headers instead. They still resolve the same way for anyone including them, and no other header moves. Changelog: [Internal] Differential Revision: D121187558
Summary: Changelog: [Internal] Update the timing module to use `React/Debug.h` umbrella include instead of a direct one. Differential Revision: D120137164
Summary: Changelog: [Internal] Update the bridging module to use `React/Bridging.h` and `React/RendererCore.h` umbrella includes instead of direct ones. Differential Revision: D120311601
…g module Summary: Changelog: [Internal] Update the jsinspector-modern/tracing module to use `React/Timing.h` umbrella include instead of a direct one. Differential Revision: D120313623
…module Summary: Changelog: [Internal] Update the react/renderer/scheduler module to use the `React/RendererCore.h`, `React/Utils.h`, and `React/ComponentRegistry.h` umbrella includes instead of direct ones. Differential Revision: D120315036
Summary: Changelog: [Internal] Update the react/runtime module to use the `React/CallInvoker.h`, `React/RuntimeExecutor.h`, and `React/JSBigString.h` umbrella includes instead of direct ones. Differential Revision: D120316197
j-piasecki
force-pushed
the
export-D120316197
branch
from
September 22, 2026 13:17
e11ff37 to
2d1e5ce
Compare
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120316197. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Update the react/runtime module to use the
React/CallInvoker.h,React/RuntimeExecutor.h, andReact/JSBigString.humbrella includes instead of direct ones.Differential Revision: D120316197