Skip to content

Remove default payload factory static storage (#59517) - #59517

Closed
javache wants to merge 4 commits into
react:mainfrom
javache:export-D127583053
Closed

javache wants to merge 4 commits into
react:mainfrom
javache:export-D127583053

Conversation

@javache

@javache javache commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Return the stateless payload callable directly instead of caching a std::function, avoiding its dynamic static initialization and teardown without changing the factory API or payload behaviour.

Changelog: [Internal]

Differential Revision: D127583053

Summary:
Pull Request resolved: react#59489

Enforce constant initialization for eligible native globals, static defaults, synchronization primitives, and thread-local state without changing their mutability or lifetime.

Changelog: [Internal]

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D127576609
Summary:
Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton.

Changelog: [Internal]

Differential Revision: D127577561
Summary:
Remove dynamic initialization and heap allocation from fixed Fabric command lookups and the debug layout-only prop list. Preserve exact matching and use length-indexed candidate groups to avoid scanning the full command tables.

Changelog: [Internal]

Differential Revision: D127582468
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2026
@meta-codesync

meta-codesync Bot commented Oct 26, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127583053.

Summary:
Pull Request resolved: react#59517

Return the stateless payload callable directly instead of caching a std::function, avoiding its dynamic static initialization and teardown without changing the factory API or payload behaviour.

Changelog: [Internal]

Differential Revision: D127583053
@meta-codesync meta-codesync Bot changed the title Remove default payload factory static storage Remove default payload factory static storage (#59517) Oct 26, 2026
@meta-codesync meta-codesync Bot closed this in 7225d43 Oct 27, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 27, 2026
@meta-codesync

meta-codesync Bot commented Oct 27, 2026

Copy link
Copy Markdown

This pull request has been merged in 7225d43.

@javache
javache deleted the export-D127583053 branch October 27, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant