Expand silk-native with visual primitives and forms - #16
Merged
Conversation
Ship Surface through Progress plus Input/Textarea/Field/Checkbox/Switch/RadioGroup on the same silk-core recipes as web, with RNW a11y compat, fixtures, and gates. Slider stays deferred to avoid forking the shared array-valued contract. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: e848f12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…n first paint. Keep RadioGroup item spacing in the style mapper, leave disabled Switch thumbs on surface, and seed reduce-motion from matchMedia so motion never flashes before the OS preference resolves. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…ce-motion probe failures. Storybook's state control now reseeds checkbox/field defaults without a remount race, and AccessibilityInfo errors fall back to allowing motion instead of sticking on the optimistic reduced-motion default. Co-authored-by: Cursor <cursoragent@cursor.com>
Apply fixed size to an inner View and row layout on Pressable, matching RadioGroup.Item so labels are not clipped by the checkbox dimensions. Co-authored-by: Cursor <cursoragent@cursor.com>
Custom Label/Description/Error nativeIDs were ignored, so group controls could point accessibilityLabelledBy at the generated id instead of the slot view. Co-authored-by: Cursor <cursoragent@cursor.com>
The children-beside-box fix pushed isolated Checkbox to 2919 B; give modest headroom so CI tracks real regressions. Co-authored-by: Cursor <cursoragent@cursor.com>
…eselect. Keep descriptions/errors under the label in horizontal fields, derive Switch thumb travel from measured track width, and match web by not re-emitting RadioGroup changes for the active item. Co-authored-by: Cursor <cursoragent@cursor.com>
…lves. On RNW, keep prefers-reduced-motion as the source of truth so Storybook and tests do not re-enable motion when AccessibilityInfo disagrees. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the legacy MediaQueryList listener path and assert AccessibilityInfo is skipped when matchMedia is available. Co-authored-by: Cursor <cursoragent@cursor.com>
…ce until Reduce Motion is confirmed. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 013eedd. Configure here.
Set iOS accessibilityLevel from the recipe level alongside RNW aria-level. Co-authored-by: Cursor <cursoragent@cursor.com>
Preserve cross-platform accessibility and first-frame behavior while adding scalable mapper and budget drift guards. Co-authored-by: Cursor <cursoragent@cursor.com>
…d mapper output. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@reactive/silk-nativewith visual primitives (Surface,Card,Heading,Badge,Separator,Avatar,StatusDot,Skeleton,Spinner,Progress) and forms (Input,Textarea,Field,Checkbox,Switch,RadioGroup) on the same silk-core recipes as web.useReducedMotion, RNW a11y compat helpers, and Field wiring that mirrors the web contract.Slider(documented) so the array-valued multi-thumb contract is not forked; updates docs (NativeSettingsForm fixture + stories), example app, perf budgets, and packed-consumer check.Test plan
yarn workspace @reactive/silk-native test(59)yarn workspace @reactive/silk-docs test(376)node scripts/perf-budgets.mjsnode scripts/packed-consumer-check.mjsyarn workspace @reactive/silk-native-example testapps/native-example/README.md(shadows, spinner, switch, TalkBack/VoiceOver, RTL)Made with Cursor