Please note we can't commit to any timeline.
Describe the bug 🐞
Making initialPauseState required on the timer overload breaks the previously unambiguous source.BatchIf(pause, timer: ticks) call shape, including the form with an explicit scheduler. The new overload set has no forwarding replacement for that shape.
Step to reproduce
Compile changes.BatchIf(pause, timer: timer), and changes.BatchIf(pause, timer: timer, scheduler: scheduler), against current main.
Regression tests/checks:
NamedTimerWithoutInitialState_StartsUnpaused; NamedTimerWithoutInitialState_FlushesOnTimer
Reproduction repository
https://github.com/reactivemarbles/DynamicData/tree/85ee49cfd54d8782c36ed137886d318e942345c4
Regression tests and fixes:
https://github.com/reactivemarbles/DynamicData/tree/u/dacullop/main/pr-1165-review
Expected behavior
Both previously supported forms should compile, begin unpaused, and use the timer to flush explicitly paused batches.
Screenshots 🖼️
N/A.
IDE
N/A; command-line reproduction.
Operating system
Windows.
Version
.NET SDK 10.0.401; net9.0 test target.
Device
N/A.
DynamicData Version
Main 10.0-preview at 85ee49c. The related 9.5 candidate is PR #1165 at 3d76872.
Additional information ℹ️
Four repository call expressions fail compilation with CS7036 for the missing initialPauseState argument. After adding the forwarding overload, all four behavioral cases pass.
Please note we can't commit to any timeline.
Describe the bug 🐞
Making initialPauseState required on the timer overload breaks the previously unambiguous source.BatchIf(pause, timer: ticks) call shape, including the form with an explicit scheduler. The new overload set has no forwarding replacement for that shape.
Step to reproduce
Compile changes.BatchIf(pause, timer: timer), and changes.BatchIf(pause, timer: timer, scheduler: scheduler), against current main.
Regression tests/checks:
Reproduction repository
https://github.com/reactivemarbles/DynamicData/tree/85ee49cfd54d8782c36ed137886d318e942345c4
Regression tests and fixes:
https://github.com/reactivemarbles/DynamicData/tree/u/dacullop/main/pr-1165-review
Expected behavior
Both previously supported forms should compile, begin unpaused, and use the timer to flush explicitly paused batches.
Screenshots 🖼️
N/A.
IDE
N/A; command-line reproduction.
Operating system
Windows.
Version
.NET SDK 10.0.401; net9.0 test target.
Device
N/A.
DynamicData Version
Main 10.0-preview at 85ee49c. The related 9.5 candidate is PR #1165 at 3d76872.
Additional information ℹ️
Four repository call expressions fail compilation with CS7036 for the missing initialPauseState argument. After adding the forwarding overload, all four behavioral cases pass.