Repository navigation
test: set package_dialect on the header metrics RpcContext - #1213
Merged
Merged
Conversation
#1204 built an RpcContext literal in the health metrics test. #1211 added package_dialect to RpcContext and updated the other test literals to false. The two pulls merged cleanly and left this initializer missing the field, so the node test crate does not compile. package_dialect is false here, the off default those other literals use. The rest of #1204 already matches the NodeEnv, NodeConfig, and RpcContext fields #1211 added, and it does not call the helpers that pull removed. Co-authored-by: Brandon Black <reardencode@users.noreply.github.com>
rearden-grok
Bot
deleted the
cursor/fix-rpccontext-package-dialect-6048
branch
October 26, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1204 and #1211 merged one after the other. Git merged them without a textual conflict, and master
914e32ecdoes not compile the node tests.#1204 added
crates/rbitcoin-node/tests/health/metrics.rs, which builds anRpcContextliteral forgetblockchaininfo. #1211 addedpackage_dialecttoRpcContext(theRBITCOIN_RPC_PACKAGE_DIALECTknob, passed in throughNodeEnv) and set that field tofalseon the other test literals. This initializer still omitted the field, so rustc reportserror[E0063]: missing field package_dialect.The literal now sets
package_dialect: false, the same off default as those other tests. The other files #1204 added already include theNodeEnv,NodeConfig, andChainHubfields #1211 added, and they do not callsh_force_rebuild(),bq_assign_stop_bytes(), or the env locks that pull removed.cargo check -p rbitcoin-node --testsandcargo clippy -p rbitcoin-node --all-targets -- -D warningsare green locally. Workspace tests stay on GitHub Actions.